-
Notifications
You must be signed in to change notification settings - Fork 427
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat: Rework config hierarchy (#3166)
<!-- Feel free to delete comments as you fill this in --> - add remaining fields to the schema - deprecate `account` - implement and use a helper function for matching provider versions in acceptance tests - use helpers to fill config values - add acceptance tests for all fields in the config - move some code to internal package - improve documentation: describe config hierarchy and provide better config file examples - improve and test sdk.MergeConfig - move mock helper to a separate package because it caused unnecessarily registered `sqlmock` driver in one of the tests <!-- summary of changes --> ## Test Plan <!-- detail ways in which this PR has been tested or needs to be tested --> * [x] acceptance tests <!-- add more below if you think they are relevant --> * [x] unit tests ## References <!-- issues documentation links, etc --> #1881 #2145 #2925 #2983 #3104 ## TODO - acceptance test for fields regarding private keys - will be done in SNOW-1754319 - unskip some tests after creating a compatible config for older versions
- Loading branch information
1 parent
edc46cc
commit 04cd9f0
Showing
46 changed files
with
1,890 additions
and
550 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.