[Feature]: Improve documentation for snowflake_grant_privileges_to_account_role

[bdumford-OM1]

Use Cases or Problem Statement

This is not a huge deal, but could the documentation for snowflake_grant_privileges_to_account_role be improved? Specifically, there needs to be better documentation for how to migrate from the deprecated snowflake_procedure_grant resource to snowflake_grant_privileges_to_account_role.

When migrating from the snowflake_procedure_grant resource, it was not at all obvious as to where to put the argument_data_types. After a lot of searching, I found the answer in issue #2375 and on the CREATING_ISSUES page. Since there is a solution available, it would make sense to document it in the appropriate places.

Category

category:other

Object type(s)

No response

Proposal

An example for migrating from the snowflake_procedure_grant should be added to the MIGRATION_GUIDE. Additionally, an example like the one here should be added to the Terraform registry page for snowflake_grant_privileges_to_account_role.

How much impact is this issue causing?

Low

Additional Information

No response

Would you like to implement a fix?

• Yeah, I'll take it 😎

[sfc-gh-jmichalak]

Hi @bdumford-OM1 👋 Thanks for the feedback. These things can be added to our docs. Currently we're reworking essential objects on our road to v1. We welcome community contributions based on our contribution guide.

MIGRATION_GUIDE is updated manually, and snowflake_grant_privileges_to_account_role example is located in examples/resources/snowflake_grant_privileges_to_account_role/resource.tf.

[sfc-gh-jmichalak]

Hi, we've released v0.96.0, which adjusts the documentation.

We've added an example to https://registry.terraform.io/providers/Snowflake-Labs/snowflake/latest/docs/guides/identifiers. Also, we've decided not to include a separate example in snowflake_grant_privileges_to_account_role because now we highly recommend using <resource_name>.fully_qualified_name to reference other objects. All of the examples were adjusted to use this field and we added an entry to the migration guide about this change. But we left a note below that instead of using this new field, IDs can be constructed manually by hand, like before.

Let us know if this works for you!

[sfc-gh-jmichalak]

Closing the issue due to inactivity. Please create a new one if you have more suggestions.