-
Notifications
You must be signed in to change notification settings - Fork 427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: support different tag association queries for COLUMN object types #1380
fix: support different tag association queries for COLUMN object types #1380
Conversation
/ok-to-test sha=be77caa |
Integration tests failure for be77caa |
/ok-to-test sha=be77caa |
Integration tests failure for be77caa |
Hello @rmorris1218! There is a minor issue with the test case TestTableColumnName. If you could please correct then we can get this PR merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are calling ALTER TABLE x ALTER COLUMN y when should be:
ALTER TABLE x MODIFY COLUMN y
Thanks for the heads up! Updated the syntax for these. |
@sfc-gh-swinkler any chance this can be reviewed by the Snowflake team? It's a blocker for us and the requested changes seems to be already applied by the owner. Let me know if I can help with something |
/ok-to-test sha=0c04191 |
Integration tests failure for 0c04191 |
Sorry this slipped through the cracks. This looks okay to me. what i will do is merge it and resolve any workflow errors myself and get in the next release. |
This is intended to close #1201 by implementing some logic to handle the slightly different query needed for
COLUMN
tag associations vs. other object types.Test Plan
References