Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support different tag association queries for COLUMN object types #1380

Conversation

rmorris1218
Copy link
Contributor

This is intended to close #1201 by implementing some logic to handle the slightly different query needed for COLUMN tag associations vs. other object types.

Test Plan

  • acceptance tests

References

@sfc-gh-swinkler sfc-gh-swinkler changed the title support different tag association queries for COLUMN object types fix: support different tag association queries for COLUMN object types Dec 7, 2022
@sfc-gh-swinkler
Copy link
Collaborator

/ok-to-test sha=be77caa

@github-actions
Copy link

github-actions bot commented Dec 7, 2022

Integration tests failure for be77caa

@sfc-gh-swinkler
Copy link
Collaborator

/ok-to-test sha=be77caa

@github-actions
Copy link

Integration tests failure for be77caa

@sfc-gh-swinkler
Copy link
Collaborator

    tag_association_test.go:45: 
        	Error Trace:	/home/runner/work/terraform-provider-snowflake/terraform-provider-snowflake/pkg/snowflake/tag_association_test.go:45
        	Error:      	Not equal: 
        	            	expected: "c"
        	            	actual  : "\"a\".\"b\".\"c\""
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -1 +1 @@
        	            	-c
        	            	+"a"."b"."c"
        	Test:       	TestTableColumnName

Hello @rmorris1218! There is a minor issue with the test case TestTableColumnName. If you could please correct then we can get this PR merged.

Copy link

@AndresPeralta AndresPeralta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are calling ALTER TABLE x ALTER COLUMN y when should be:
ALTER TABLE x MODIFY COLUMN y

pkg/snowflake/tag_association.go Outdated Show resolved Hide resolved
pkg/snowflake/tag_association.go Outdated Show resolved Hide resolved
pkg/snowflake/tag_association_test.go Outdated Show resolved Hide resolved
pkg/snowflake/tag_association_test.go Outdated Show resolved Hide resolved
pkg/snowflake/tag_association_test.go Outdated Show resolved Hide resolved
pkg/snowflake/tag_association_test.go Outdated Show resolved Hide resolved
@rmorris1218
Copy link
Contributor Author

We are calling ALTER TABLE x ALTER COLUMN y when should be: ALTER TABLE x MODIFY COLUMN y

Thanks for the heads up! Updated the syntax for these.

@ldardick
Copy link

@sfc-gh-swinkler any chance this can be reviewed by the Snowflake team? It's a blocker for us and the requested changes seems to be already applied by the owner. Let me know if I can help with something

AndresPeralta
AndresPeralta approved these changes Jan 19, 2023
@rmorris1218 rmorris1218 marked this pull request as ready for review January 19, 2023 14:26
@Snowflake-Labs Snowflake-Labs deleted a comment from scottwinkler Feb 1, 2023
@sfc-gh-swinkler
Copy link
Collaborator

/ok-to-test sha=0c04191

@github-actions
Copy link

github-actions bot commented Feb 1, 2023

Integration tests failure for 0c04191

@sfc-gh-swinkler
Copy link
Collaborator

Sorry this slipped through the cracks. This looks okay to me. what i will do is merge it and resolve any workflow errors myself and get in the next release.

@sfc-gh-swinkler sfc-gh-swinkler merged commit 546d0a1 into Snowflake-Labs:main Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

snowflake_tag_association does not support column-level tagging
4 participants