fix: be more cautious when setting db id to empty #1725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Integration tests failure for 7a2dad4085fea5d47f2ffb491746a4ba13df6f85 |
|
Integration tests failure for ba9fc66e548e898881dd4340ef02dbacf0664fb6 |
|
Integration tests success for f87e63b1dafe8afa823a28aa134b629967d3d6f6 |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Integration tests failure for a33a5d3cb3c53b89195c53d820570e828d745510 |
sfc-gh-ngaberel
previously approved these changes
Apr 18, 2023
|
Integration tests failure for edf756f8d8733a5bd6c4a54220fb201a652e2811 |
|
Integration tests failure for c0b76409e0bdc3ed9e8a96f6c213eb9bb0328ce8 |
|
Integration tests success for a86176def8f18e9514c4baaab6c1b4c8c7280847 |
|
Integration tests success for 276c7fddae732882396f1bd84f1da67d7918e6b2 |
sfc-gh-ngaberel
approved these changes
Apr 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for #1674
this adds back in the initial scan on database, and only sets the database id to "" if the error is ErrNoRows, and throws exceptions for all else, without setting the id to "". This is the original behavior. Retaining the ListDatabases function which is necessary in case there is more than one match for the given database name.
Also reverted read to use d.Id() instead of custom import function, which really wasn't necessary here anyways.