Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Handle optional account fields in the state upgrader correctly #3330

Merged
merged 6 commits into from
Jan 10, 2025
Merged

fix: Handle optional account fields in the state upgrader correctly #3330

merged 6 commits into from
Jan 10, 2025

Conversation

sfc-gh-jmichalak
Copy link
Collaborator

@sfc-gh-jmichalak sfc-gh-jmichalak commented Jan 8, 2025 •
edited
Loading

  • Fix handling optional account fields in the state upgrader. This error happened after importing accounts where the optional fields were not set—they are not populated in Import/Read. This resulted in empty values and panics.
  • The change has been verified manually. The acceptance test can be added in a follow-up (linked ticket) because of the potential limitations of the plugin SDK.
  • Fix failing tests.
  • Fix a few issues in docs.

Test Plan

  • acceptance tests
  • …

References

#3328 #3332

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 8, 2025

Integration tests failure for 1a44357ffb09b9c87744b4532be03c03e40fa46e

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2025

Integration tests failure for f1447b1ca3cd4b228f984a2335ad4412c2fe2980

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2025

Integration tests cancelled for c7e463d17d664cf2efa7a8f1910ba5e1ccd7a432

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2025

Integration tests failure for 937c80af64dda25590f6b72aacd259e9d8732df0

@sfc-gh-asawicki sfc-gh-asawicki merged commit 2ab1d07 into dev Jan 10, 2025
8 of 9 checks passed
@sfc-gh-asawicki sfc-gh-asawicki deleted the fix-3328 branch January 10, 2025 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-asawicki sfc-gh-asawicki sfc-gh-asawicki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-jmichalak @sfc-gh-asawicki