role_grants: update read to only use grants specific to the tf resource #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/ok-to-test sha=1a58fef |
|
Integration tests failure for 1a58fef |
|
@cstkpk could you look at the errors and update your branch 😄 |
alldoami
suggested changes
Apr 28, 2021
|
/ok-to-test sha=23a1375 |
|
Integration tests success for 23a1375 |
alldoami
approved these changes
May 7, 2021
anton-chekanov
pushed a commit
to anton-chekanov/terraform-provider-snowflake
that referenced
this pull request
Jan 25, 2022
daniepett
pushed a commit
to daniepett/terraform-provider-snowflake
that referenced
this pull request
Feb 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current behavior is to query Snowflake for all grants to the specified role when a role grant is read, updated, or deleted. This means the update or delete to applies to all grants to the specified role rather than just the grants that are part of the terraform resource. This causes issues when there are multiple resources handling grants to the same role, as well as when there is a role hierarchy (see issues linked below for more info).
These changes modify the role grant read to look at only the grants that are part of the specified terraform resource. This allows for more flexible use of terraform modules and eliminates issues with role hierarchies.
Test Plan
References
189
512