Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor with remote exporter #1066

Merged
merged 1 commit into from
Dec 19, 2023
Merged

Refactor with remote exporter #1066

merged 1 commit into from
Dec 19, 2023

Conversation

yrong
Copy link
Contributor

@yrong yrong commented Dec 18, 2023

@yrong yrong marked this pull request as ready for review December 18, 2023 01:23
claravanstaden
claravanstaden approved these changes Dec 18, 2023
View reviewed changes
Copy link
Contributor

@claravanstaden claravanstaden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, looks great!

alistair-singh
alistair-singh approved these changes Dec 18, 2023
View reviewed changes
Copy link
Contributor

@alistair-singh alistair-singh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@yrong
Copy link
Contributor Author

yrong commented Dec 18, 2023 •
edited
Loading

@alistair-singh To address your concern add the check to ensure BridgeHubEthereumBaseFee is correctly charged from sender in Snowfork/polkadot-sdk@79f6294

@yrong
Copy link
Contributor Author

yrong commented Dec 19, 2023

@claravanstaden There are some comments for the format change in Snowfork/polkadot-sdk#71, Please check if it's necessary or not.

@claravanstaden
Copy link
Contributor

Hey @yrong, sorry about that. Fix here: Snowfork/polkadot-sdk#76

@yrong yrong force-pushed the ron/refactor-with-remote-exporter branch from 2ccad76 to cd71056 Compare December 19, 2023 12:30
@yrong yrong merged commit 674a28e into main Dec 19, 2023
7 checks passed
@yrong yrong deleted the ron/refactor-with-remote-exporter branch December 19, 2023 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alistair-singh alistair-singh alistair-singh approved these changes

@claravanstaden claravanstaden claravanstaden approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yrong @claravanstaden @alistair-singh