-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Verify that channel exists when validating outbound message #1067
Conversation
3febd4b
to
83650f2
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1067 +/- ##
==========================================
+ Coverage 80.55% 80.57% +0.02%
==========================================
Files 55 55
Lines 2273 2276 +3
Branches 71 71
==========================================
+ Hits 1831 1834 +3
Misses 425 425
Partials 17 17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
}); | ||
} | ||
|
||
pub fn send_transfer_token_message_insufficient_fund<Runtime, XcmConfig>( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we remove this test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a test utility that's called from multiple tests, not a test itself. This was duplicated for each test case and I refactored it into a single test utility that allows you to specify fees and the error you expect.
ad08d11
to
cca88bb
Compare
Polkadot-sdk: Snowfork/polkadot-sdk#73
This is a simpler version of #1047
Fixes: SNO-771