Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for e2e setup #1219

Merged
merged 7 commits into from
Jun 4, 2024
Merged

Fix for e2e setup #1219

merged 7 commits into from
Jun 4, 2024

Conversation

yrong
Copy link
Contributor

@yrong yrong commented Jun 4, 2024

No description provided.

Copy link
Contributor

@claravanstaden claravanstaden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me! There was a problem with geth but --state.scheme=hash fixes it, thanks!

I did notice that the beacon relayer restarts with write to parachain: parachain write status was dropped, invalid, usurped or finality timed out, but when I look at Polkadot JS, the beacon headers are imported. I wonder if it is a problem with the Go substrate client. Did you see the same thing?

@yrong
Copy link
Contributor Author

yrong commented Jun 4, 2024

Did you see the same thing?

Yeah, same issue from my side. Still investigating and guess something related to the fast slot hack?

Updates:
Change the fast slot time from 1s to 6s and it work as expected but will slow the e2e setup. Or maybe we can increase the interval here.

ticker := time.NewTicker(time.Second * 10)

{"@timestamp":"2024-06-04T17:51:22.204227+08:00","blockRoot":"0xdfa79630efa7a41c10f4710a5870bc0b2f158ec0dd6fcebb77ec7398e3a1eab0","level":"info","message":"syncing finalized header from Ethereum beacon client","slot":288}
{"@timestamp":"2024-06-04T17:52:22.242619+08:00","block":"0x5afc53a57f2fe6984a26383add8706be1708f3b0971bfdbee3304fbb1dd2ab3e","extrinsic":"EthereumBeaconClient.submit","level":"debug","message":"extrinsic finalized"}
{"@timestamp":"2024-06-04T17:52:27.549197+08:00","blockRoot":"0x9900c996d25bd4a889871ae423f1325e762f0b903bfa88fddbbbd926026358d3","level":"info","message":"syncing finalized header from Ethereum beacon client","slot":320}
{"@timestamp":"2024-06-04T17:53:22.481526+08:00","block":"0xebe2c316785a757763163b0fc9658c356fbd18d811f099b5e89396dc8f2d72a5","extrinsic":"EthereumBeaconClient.submit","level":"debug","message":"extrinsic finalized"}
{"@timestamp":"2024-06-04T17:53:27.284686+08:00","blockRoot":"0xe9cece6b3831a0d4eb6b5a69c531a4561f469ad1d7377240654b6958a61e2e71","level":"info","message":"syncing finalized header from Ethereum beacon client","slot":352}
{"@timestamp":"2024-06-04T17:54:46.816956+08:00","block":"0xd873e3b04b0b6c8a168d9d54334486440757aa271eb595c6df70d40e5cac3e4d","extrinsic":"EthereumBeaconClient.submit","level":"debug","message":"extrinsic finalized"}
{"@timestamp":"2024-06-04T17:54:46.925848+08:00","blockRoot":"0x6f9b7b38e54d7174ce4122cac236c00a8385b958c2cdbf762164f2352779b5ff","level":"info","message":"syncing finalized header from Ethereum beacon client","slot":384}
{"@timestamp":"2024-06-04T17:55:22.967114+08:00","block":"0x5ea528923504fe7b7fa0bb5427018aa1edaf62b71aa4bd19b43e09d131d261bd","extrinsic":"EthereumBeaconClient.submit","level":"debug","message":"extrinsic finalized"}
...

Anyway, I'm not too worried about the issue seems it won't be a problem for production.

@yrong yrong marked this pull request as ready for review June 4, 2024 09:05
Copy link
Collaborator

@vgeddes vgeddes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, 🚀

Copy link
Contributor

@claravanstaden claravanstaden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for looking into this!

@yrong yrong merged commit ed49363 into main Jun 4, 2024
2 checks passed
@yrong yrong deleted the ron/fix-e2e-setup branch June 4, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants