Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: azule -> pyzule #24

Merged
merged 5 commits into from
Apr 18, 2024
Merged

chore: azule -> pyzule #24

merged 5 commits into from
Apr 18, 2024

Conversation

asdfzxcvbn
Copy link

this PR changes the FLEX submodule to my fork (to fix linux compilation) while i wait for my PR to be merged.

speaking of FLEX.. it was never even being compiled. SUBMODULES wasn't being used correctly, so i have no idea how it was working before.

i also removed the Cephei frameworks from the repo, as they'll be injected automatically with pyzule.

@asdfzxcvbn asdfzxcvbn marked this pull request as ready for review April 14, 2024 02:49
@asdfzxcvbn asdfzxcvbn marked this pull request as draft April 15, 2024 02:09
@asdfzxcvbn asdfzxcvbn marked this pull request as ready for review April 15, 2024 02:52
@SoCuul
Copy link
Owner

SoCuul commented Apr 15, 2024

Flex seemed to be compiled for me, as it was built and linked into the final build. In all honestly, I'm still super new to this so I'm not sure how the theos build process works in-depth.

@SoCuul
Copy link
Owner

SoCuul commented Apr 16, 2024

Would it be possible to stick with the upstream FLEX repo until your PR gets merged? Just trying to stay consistent.

@asdfzxcvbn
Copy link
Author

Would it be possible to stick with the upstream FLEX repo until your PR gets merged? Just trying to stay consistent.

i guess so, but then compiling wont work on linux again, so i wont really be able to help as much

@SoCuul
Copy link
Owner

SoCuul commented Apr 17, 2024

Has this pr fixed the SUBMODULES problem not compiling FLEX?

@asdfzxcvbn
Copy link
Author

Has this pr fixed the SUBMODULES problem not compiling FLEX?

yep!

@SoCuul
Copy link
Owner

SoCuul commented Apr 17, 2024

Has this pr fixed the SUBMODULES problem not compiling FLEX?

yep!

Thank you so much! I'll test this on my machine as soon as possible, then merge it into main.

@SoCuul SoCuul self-assigned this Apr 17, 2024
@SoCuul SoCuul merged commit 5f8f529 into SoCuul:main Apr 18, 2024
1 check failed
@SoCuul
Copy link
Owner

SoCuul commented Apr 18, 2024

Thank you so much for your help with all of this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants