-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Activate GitHub workflow for online building of SCInsta IPA #28
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, just needs a few changes before it can be merged.
After the review, you can merge your commit into the main branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything seems to look good. Before I merge it though, could you test out the workflow with the commits I've added to the PR.
If everything works as intended, I'll merge it as soon as I can!
Update build.sh to fix the issue of IPA file not being found. Added script commands to install pyzule. Modified the build.sh script by replacing certain instructions originally designated for BHInsta with those intended for SCInsta. You can review my latest PR to verify these changes. |
It's super inefficient to install pyzule each time someone tries to build it, as they only need to install it once. Could you just add it as another step in the buildapp workflow? Also the build.sh functionality should be independant of the workflow. The workflow calls it from the repo folder, so it should work fine as-is. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All that needs to be changed is moving the pyzule stuff to a build step and reverting the changes in build.sh
. The script should run fine if in the workflow step it cds into the folder, as all the paths in the shell script are relative to the current directory.
Initially, you can proceed with the merge, but it's imperative to ensure that the "pyzule" tool is installed using GitHub Actions to facilitate the building of the IPA. |
I do not feel comfortable merging this into the main branch in its current state, as it would cause confusion for users who do not understand why the workflow fails on their end. |
@zeuikli If you're working on this, what do you think about adding a dropdown in the workflow settings to select between sideloaded ipa, rootless and rootful |
@SoCuul I have already updated the Github workflow and package dependencies to enable building IPA and deb files. |
Thank you so much for your work! I'll take a look at the PR when I can. |
W zeuiki now sideloading this won't more complicated than it already is |
I still plan on implementing this when I can find the time. Kinda burned out rn from working on this atm. |
Example : https://github.com/zeuikli/BHInsta/actions/runs/8732321318
Run workflow :
Please enter the iOS SDK version and the IPA URL, then wait for the completion of the IPA build.
Build Status :
Confirm that the IPA file can be installed via eSign, but note that the image download feature is still not functioning properly.