[Feature] Decouple the Generators from the Illuminate Configuration Repository #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the generator was aware of the illuminate configuration contract, which made it difficult to use multiple signed request configurations in a single project. With the addition of the configuration adapters we can now have many implementations of configurations.
Jaspaul
commented
May 18, 2017
| */ | ||
| public function __construct(Generator $generator) | ||
| public function __construct(Configuration $configuration) |
There was a problem hiding this comment.
I feel like this is a breaking change on any dependent projects so we should update to v0.2
jshayes
approved these changes
May 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change decouples the generator from the illuminate configuration repository by introducing an adapter layer. The major advantage this will provide is giving us the ability to have multiple custom signed requests within a single project.
This resolves half of the requested functionality in #13.