feat(logo): met à jour le logo de l'application partout #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closes #178 |
benguedj
approved these changes
May 7, 2021
yannickjacqueline
suggested changes
May 7, 2021
front/components/HeaderApp.tsx
Outdated
| <Text style={styles.appLogo}>{Labels.appName}</Text> | ||
| <View style={styles.underline}></View> | ||
| <View style={styles.appLogo}> | ||
| <AppLogo height={70} /> |
There was a problem hiding this comment.
Pour la hauteur, appeler une des constantes
There was a problem hiding this comment.
Ici, compliqué d'utiliser une des constantes de Sizes dont aucune valeur ne correspond au chiffre que je veux
There was a problem hiding this comment.
Du coup, pourquoi pas en créer une spécifique au logo x)
Alezco
force-pushed
the
onboarding-app-logo
branch
from
abaf1ba to
5c78375
Compare
Alezco
force-pushed
the
onboarding-app-logo
branch
from
5c78375 to
3bb7776
Compare
SocialGroovyBot
added a commit
that referenced
this pull request
May 7, 2021
# [1.22.0](v1.21.0...v1.22.0) (2021-05-07) ### Features * **logo:** met à jour le logo de l'application partout ([#196](#196)) ([a30dc2d](a30dc2d))
|
🎉 This PR is included in version 1.22.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.