Skip to content

Commit

Permalink
chore: remove useless comments (#381)
Browse files Browse the repository at this point in the history
  • Loading branch information
gary-van-woerkens authored Feb 23, 2023
1 parent 2da2693 commit 6678249
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 72 deletions.
71 changes: 1 addition & 70 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,67 +1,3 @@
# FROM node:18-alpine AS base

# # Install dependencies only when needed
# FROM base AS deps
# # Check https://github.com/nodejs/docker-node/tree/b4117f9333da4138b03a546ec926ef50a31506c3#nodealpine to understand why libc6-compat might be needed.
# RUN apk add --no-cache libc6-compat
# WORKDIR /app

# # Install dependencies based on the preferred package manager
# COPY package.json yarn.lock ./
# RUN yarn --frozen-lockfile
# # RUN \
# # if [ -f yarn.lock ]; then yarn --frozen-lockfile; \
# # elif [ -f package-lock.json ]; then npm ci; \
# # elif [ -f pnpm-lock.yaml ]; then yarn global add pnpm && pnpm i --frozen-lockfile; \
# # else echo "Lockfile not found." && exit 1; \
# # fi


# # Rebuild the source code only when needed
# FROM base AS builder
# WORKDIR /app
# COPY --from=deps /app/node_modules ./node_modules
# COPY . .

# # Next.js collects completely anonymous telemetry data about general usage.
# # Learn more here: https://nextjs.org/telemetry
# # Uncomment the following line in case you want to disable telemetry during the build.
# ENV NEXT_TELEMETRY_DISABLED 1
# ARG NEXT_PUBLIC_HASURA_URL
# ENV NEXT_PUBLIC_HASURA_URL $NEXT_PUBLIC_HASURA_URL
# ENV NODE_OPTIONS --openssl-legacy-provider

# RUN yarn build

# # If using npm comment out above and use below instead
# # RUN npm run build

# # Production image, copy all the files and run next
# FROM base AS runner
# WORKDIR /app

# ENV NODE_ENV production
# # Uncomment the following line in case you want to disable telemetry during runtime.
# ENV NEXT_TELEMETRY_DISABLED 1

# RUN addgroup --system --gid 1001 nodejs
# RUN adduser --system --uid 1001 nextjs

# COPY --from=builder /app/public ./public

# # Automatically leverage output traces to reduce image size
# # https://nextjs.org/docs/advanced-features/output-file-tracing
# COPY --from=builder --chown=nextjs:nodejs /app/.next/standalone ./
# COPY --from=builder --chown=nextjs:nodejs /app/.next/static ./.next/static

# USER 1001

# EXPOSE 3000

# ENV PORT 3000

# CMD ["node", "server.js"]

# Install dependencies only when needed
FROM node:alpine AS deps
# Check https://github.com/nodejs/docker-node/tree/b4117f9333da4138b03a546ec926ef50a31506c3#nodealpine to understand why libc6-compat might be needed.
Expand All @@ -72,12 +8,7 @@ RUN yarn install --frozen-lockfile

# Rebuild the source code only when needed
FROM node:alpine AS builder
# RUN apk --no-cache add g++ make python3
# RUN apk --no-cache add --virtual native-deps \
# g++ gcc libgcc libstdc++ linux-headers make python && \
# npm install --quiet node-gyp -g && \
# npm install --quiet && \
# apk del native-deps

WORKDIR /app
COPY --from=deps /app/node_modules ./node_modules
COPY . .
Expand Down
2 changes: 0 additions & 2 deletions packages/hasura/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,4 @@ ENV HASURA_GRAPHQL_ENABLE_TELEMETRY=false
COPY ./migrations /hasura-migrations
COPY ./metadata /hasura-metadata

# ENV HASURA_GRAPHQL_SERVER_PORT=8080

USER 1001

0 comments on commit 6678249

Please sign in to comment.