Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(report)!: Migrate to DSFR version #31

Merged
merged 30 commits into from
Sep 2, 2021
Merged

Conversation

desoindx
Copy link
Contributor

@desoindx desoindx commented Aug 4, 2021

Test are failing (because everything changed :p)
and still missing the table sort

BREAKING CHANGES:

  • The build now outputs do dist instead of build
  • dashlord.yaml taks additionnal parameters : description, entity, footer

report/www/src/index.js Outdated Show resolved Hide resolved
@desoindx desoindx force-pushed the tristanrobert/issue29 branch from 876e1f1 to f1e1302 Compare August 4, 2021 17:28
desoindx and others added 5 commits August 4, 2021 19:32
* chore(eslint): ignore build

* chore: prettier

* fix(Dashboard): a11y warning fix

* chore: lint

* chore: prettier + eslint config
@desoindx desoindx force-pushed the tristanrobert/issue29 branch from 21c0477 to ed6963c Compare August 11, 2021 13:56
desoindx and others added 2 commits August 11, 2021 16:22
* fix: favicon

* cosmetics

* fix: center-align UnknownIcon

* fix(dev): fix sample config.json

* fix: center-align all badges

* fix: bigger gauges

* fix: trends

* fix(panel): bigger subtitle

* fix: category link

* feat(branding): add entity, description, footer in config
<FooterBody description="">
<Logo>{dashlordConfig.entity}</Logo>
<FooterBodyItem>
<div dangerouslySetInnerHTML={{ __html: dashlordConfig.footer }} />
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting HTML from code is risky because it’s easy to inadvertently expose your users to a cross-site scripting (XSS) attack. (typescript.react.security.audit.react-dangerouslysetinnerhtml.react-dangerouslysetinnerhtml from Security Policy)

This comment is advisory. You do not need to address it before merging this pull request.
How do I suppress this? · Report a broken rule · Manage policy

@revolunet revolunet changed the title Migrate to DSFR version feat(report)!: Migrate to DSFR version Aug 26, 2021
Julien Bouquillon added 3 commits August 26, 2021 18:21
* fix: center-align UnknownIcon

* fix: center-align all badges

* fixes

* fix: use better report.json

* tests: better report.json

* fix(report): no pagination and shorter urls

* fix(report): hide category menu when not necessary
@revolunet revolunet marked this pull request as ready for review August 26, 2021 16:47
@revolunet revolunet merged commit d32d727 into main Sep 2, 2021
@revolunet revolunet deleted the tristanrobert/issue29 branch September 2, 2021 09:13
@github-actions
Copy link

github-actions bot commented Sep 2, 2021

🎉 This PR is included in version 1.6.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants