-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(report)!: Migrate to DSFR version #31
Conversation
Fixes #29 - add dsfr header and footer - add theme settings dark or light
876e1f1
to
f1e1302
Compare
* chore(eslint): ignore build * chore: prettier * fix(Dashboard): a11y warning fix * chore: lint * chore: prettier + eslint config
21c0477
to
ed6963c
Compare
* fix: favicon * cosmetics * fix: center-align UnknownIcon * fix(dev): fix sample config.json * fix: center-align all badges * fix: bigger gauges * fix: trends * fix(panel): bigger subtitle * fix: category link * feat(branding): add entity, description, footer in config
<FooterBody description=""> | ||
<Logo>{dashlordConfig.entity}</Logo> | ||
<FooterBodyItem> | ||
<div dangerouslySetInnerHTML={{ __html: dashlordConfig.footer }} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Setting HTML from code is risky because it’s easy to inadvertently expose your users to a cross-site scripting (XSS) attack. (typescript.react.security.audit.react-dangerouslysetinnerhtml.react-dangerouslysetinnerhtml from Security Policy)
This comment is advisory. You do not need to address it before merging this pull request.
How do I suppress this? · Report a broken rule · Manage policy
* fix: center-align UnknownIcon * fix: center-align all badges * fixes * fix: use better report.json * tests: better report.json * fix(report): no pagination and shorter urls * fix(report): hide category menu when not necessary
🎉 This PR is included in version 1.6.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Test are failing (because everything changed :p)
and still missing the table sort
BREAKING CHANGES:
dist
instead ofbuild
description
,entity
,footer