Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for BIQU Printers #1024

Merged
merged 2 commits into from
May 10, 2023
Merged

Add support for BIQU Printers #1024

merged 2 commits into from
May 10, 2023

Conversation

Musicdad12
Copy link
Contributor

Adds printers BIQU B1, BX, and Hurakan

Add support for BIQU Printers
0b37502 
Adds printers BIQU B1, BX, and Hurakan
SoftFever
SoftFever reviewed May 9, 2023
View reviewed changes
resources/profiles/BIQU/BIQU_BX_buildplate_texture.png Outdated
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we change the image size to 1024x1024?
Some machines will have issues rendering irregular large textures.

SoftFever
SoftFever reviewed May 9, 2023
View reviewed changes
resources/profiles/BIQU/BIQU_Hurakan_buildplate_texture.png Outdated
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we change the image size to 512x512 or 1024x1024?
Some machines will have issues rendering irregular large textures.

SoftFever
SoftFever requested changes May 9, 2023
View reviewed changes
Copy link
Owner

@SoftFever SoftFever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Musicdad12
Thank you for creating the profiles.
I noticed a few issues in the PR, so please take a look when you have a chance. Once the modifications have been made, you can test whether the changes are working by updating the version number in BIQU.json. This will force the copying of new profiles to the system folder.

resources/profiles/BIQU/BIQU_BX_hotend.stl Outdated Show resolved Hide resolved
resources/profiles/BIQU/BIQU_Hurakan_hotend.stl Outdated Show resolved Hide resolved
resources/profiles/BIQU.json Show resolved Hide resolved
@SoftFever
Copy link
Owner

@Musicdad12
Thank you for creating the profiles.
I noticed a few issues in the PR, so please take a look when you have a chance. Once the modifications have been made, you can test whether the changes are working by updating the version number in BIQU.json. This will force the copying of new profiles to the system folder.

@Musicdad12
Copy link
Contributor Author

All requested changes were made.

SoftFever
SoftFever approved these changes May 10, 2023
View reviewed changes
Copy link
Owner

@SoftFever SoftFever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SoftFever SoftFever merged commit c9fcc42 into SoftFever:main May 10, 2023
@SoftFever
Copy link
Owner

@Musicdad12
Just found that those BQ machine missing cover photos
Screenshot 2023-05-10 at 10 50 19 PM

@Musicdad12
Copy link
Contributor Author

Did you get the cover photos? or do I need to upload them?

@SoftFever
Copy link
Owner

Hi @Musicdad12
Thanks @fr3ak2402, he added cover photos for these printers.

@Radbmx
Copy link

Radbmx commented May 24, 2023

the biqu profiles will not load after selecting them in the add/remove. All other printers were working fine
image
image

@fr3ak2402
Copy link

@Radbmx
I have already noticed the problem and have already fixed it, which will be installed in the next few days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SoftFever SoftFever SoftFever approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Musicdad12 @SoftFever @Radbmx @fr3ak2402