Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Folgertech Printers #1048

Merged
merged 12 commits into from
May 20, 2023
Merged

Add Folgertech Printers #1048

merged 12 commits into from
May 20, 2023

Conversation

Musicdad12
Copy link
Contributor

Fixed a Typo in one of the filament files, rendering it inoperative
Fixed filaments with a unique filament ID number
Uploaded cover images for printer models
Fixed typo in machine definition where texture and/or model was not correct

@SoftFever
Copy link
Owner

@Musicdad12
There are a lot of conflicts
Can you take a look?

@fr3ak2402
Copy link

fr3ak2402 commented May 14, 2023

@SoftFever @Musicdad12

Folgertech filaments have not been named correctly.
In the filament file the filaments were always named Folgertech Generic etc. The files themselves, however, only Generic etc.

I don't think this will work and would cause problems with other printers.

Bildschirmfoto 2023-05-14 um 13 01 54

In addition, images have already been created for the BIQU printers in OrcaSlicer.
The profiles from the BIQU have already been included.

Moreover, the images Folgertech printer are also not in 180x180 pixels.

@Musicdad12
Copy link
Contributor Author

@SoftFever @Musicdad12

Folgertech filaments have not been named correctly. In the filament file the filaments were always named Folgertech Generic etc. The files themselves, however, only Generic etc.

I don't think this will work and would cause problems with other printers.

I will make the changes.

Bildschirmfoto 2023-05-14 um 13 01 54 In addition, images have already been created for the BIQU printers in OrcaSlicer. The profiles from the BIQU have already been included.

There were a few errors in the original BIQU files, these were corrected.

Moreover, the images Folgertech printer are also not in 180x180 pixels

I will change

@fr3ak2402
Copy link

fr3ak2402 commented May 15, 2023

@Musicdad12

The Folgertech filaments are now in order. In addition, the Folgertech printer images are now also okay.

The BIQU printer images still need to be removed, as there are already images of these models.

Why did you give the BIQU filaments a new ID?

@SoftFever
Is it at all possible to assign an own ID to filaments?

Doesn't that lead to a problem with the Bambulab Cloud synchronization if you use an ID that has not been released by BambuLab?

@Musicdad12
Copy link
Contributor Author

Musicdad12 commented May 15, 2023

@Musicdad12

The Folgertech filaments are now in order. In addition, the Folgertech printer images are now also okay.

The BIQU printer images still need to be removed, as there are already images of these models.

I am sorry, I don't know how to remove them from the pull Request. (still new at Github)

Why did you give the BIQU filaments a new ID?

I had conflicts and thought it would help. I am seeing Sekits printers on when I add/filter for ANY printer, so, I thought by giving these a unique ID, it would prevent these filaments from showing up on other machine filters

@SoftFever Is it at all possible to assign an own ID to filaments?

Doesn't that lead to a problem with the Bambulab Cloud synchronization if you use an ID that has not been released by BambuLab?

I am not aware. It seemed to work on my test version locally. Should I change them back?

@fr3ak2402
Copy link

@Musicdad12
I have already fixed the problem with the SecKit printers, you won't have that in the next version. This has nothing to do with your profiles, but had something to do with the SecKit profile.

But you can ignore the filaments from SecKit.

Have you also installed the plugin from Bambulab and are logged in? Just change that for safety back to the original IDs

@SoftFever
Copy link
Owner

LGTM.
Thanks, @Musicdad12 👍
Also, thank @fr3ak2402 for the code reviewing.

@SoftFever SoftFever changed the title Updated files for BIQU profiles Add Folgertech Printers May 20, 2023
@SoftFever SoftFever merged commit 8d96c42 into SoftFever:main May 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants