[FIX] Wrong parameter version causes Kingroon profiles doesnt load #1647
Conversation
More strings!
modified: bbl/i18n/es/OrcaSlicer_es.mo
OrcaSlicer_es.po finished
modified: resources/i18n/es/OrcaSlicer.mo
Added es_ES to text.js (spanish strings)
Added Kp3s and kp5l printers
CAMBIOS EN CUARTEL
github issue SoftFever#1646 & SoftFever#1647 Change-Id: Iab1d6984685a532011f425e704ccae039a6ef65d (cherry picked from commit 1219045039de4ac0ed677b264e6e8469e6bc72dd)
Thanks for the clarification. Do you think we can avoid renaming the file/profile names? |
|
Ok i changed cos your suggestions. I revert the changed names
El dom, 6 ago 2023, 12:17, SoftFever ***@***.***> escribió:
… Kingroon kp3s s1 comes with default firm, i put a custom profile with cura
kingoon machine default gcode. Kp3s v2 comes with klipper installed
out-of-the-box. They are different machines. El mié, 2 ago 2023, 14:42,
SoftFever *@*.***> escribió:
… <#m_-5458252537221284657_m_-977855250916023275_m_-3771630176886052174_>
Thanks for the clarification.
Make sense now👍
Do you think we can avoid renaming the file/profile names?
Existing user profiles based on them won't be loaded anymore if we rename
them.
—
Reply to this email directly, view it on GitHub
<#1647 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AENP5KWXJCCVS3XFYTTUIGTXT5VKJANCNFSM6AAAAAA26P4WSQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
There was a problem hiding this comment.
Hi @tadeu2
This is not updated yet.
Same for other process.
If you have custom profiles already based on the new name and you want to keep them.
You can find the json file in %appdata%/OrcaSlicer/user/*/process, then modify the inherits to point to the correct parent. Something like this:
"inherits": "0.20mm Standard @voron",
resources/profiles/Kingroon/process/0.12mm Standard @Kingroon KP3S PRO S1.json
Outdated
Show resolved
Hide resolved
| "from": "User", | ||
| "inherits": "0.20mm Standard @Kingroon KP3S PRO S1", | ||
| "is_custom_defined": "0", | ||
| "name": "0.20mm Standard @Kingroon KP3S PRO S1 - TADEUS", |
There was a problem hiding this comment.
the name should remain standard format
| "from": "system", | ||
| "gap_infill_speed": "40", | ||
| "infill_jerk": "15", | ||
| "inherits": "0.20mm Standard @RatRig", |
|
Ok ill correct all. Ty
El vie, 11 ago 2023, 14:02, SoftFever ***@***.***> escribió:
… ***@***.**** requested changes on this pull request.
I found a few issues.
It seems the PR has a few poteinally unintended changes like one profile
is inherited from ratrig. And some names have personal names.
—
Reply to this email directly, view it on GitHub
<#1647 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AENP5KSUYZON3F2NBPCGAXTXUYNLRANCNFSM6AAAAAA26P4WSQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Thanks for your patience. |
This reverts commit 116265c.
|
Did you test it now?
El dom, 13 ago 2023, 4:41, SoftFever ***@***.***> escribió:
… Ok ill correct all. Ty El vie, 11 ago 2023, 14:02, SoftFever *@*.
*> escribió: … <#m_119296147933951046_> @.** requested changes on this
pull request. I found a few issues. It seems the PR has a few poteinally
unintended changes like one profile is inherited from ratrig. And some
names have personal names. — Reply to this email directly, view it on
GitHub <#1647 (review)
<#1647 (review)>>,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AENP5KSUYZON3F2NBPCGAXTXUYNLRANCNFSM6AAAAAA26P4WSQ
. You are receiving this because you were mentioned.Message ID: *@*.***>
Thanks for your patience.
I'd suggest starting with the latest main branch, then change parameters
you want to tweak. But don't touch the file name and profile name
—
Reply to this email directly, view it on GitHub
<#1647 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AENP5KXPVPVQDEOYX6S2ZILXVA5GDANCNFSM6AAAAAA26P4WSQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
No description provided.