Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug fix] Fixes lightning infill with sparse infill width set to 0 causes "divide by zero" fatal error #3592

Conversation

igiannakas
Copy link
Contributor

@igiannakas igiannakas commented Jan 9, 2024

Fixes #3567.

Firstly attempt to set it to the default line width. If that is not provided either, set it to a sane default based on the nozzle diameter.

…set to 0 causes "divide by zero" fatal error
@discip
Copy link
Contributor

discip commented Jan 10, 2024

@igiannakas
If you put one of the following terms close, closes, closed, fix, fixes, fixed, resolve, resolves, resolved in front of the corresponding issue, or even PR, the respective issue or PR will be automatically closed once this PR gets merged.

e.g.:
Change Fix for #3567. to Fixes #3567..

For reference see:
https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue

@igiannakas igiannakas changed the title Fix issue #3567 - Lightning infill with sparse infill width set to 0 causes "divide by zero" fatal error Fixes #3567 - Lightning infill with sparse infill width set to 0 causes "divide by zero" fatal error Jan 10, 2024
@igiannakas
Copy link
Contributor Author

@igiannakas If you put one of the following terms close, closes, closed, fix, fixes, fixed, resolve, resolves, resolved in front of the corresponding issue, or even PR, the respective issue or PR will be automatically closed once this PR gets merged.

e.g.: Change Fix for #3567. to Fixes #3567..

For reference see: https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue

Nice I didn’t know that!!

@discip
Copy link
Contributor

discip commented Jan 11, 2024

@igiannakas
Sorry, I did not get right away why you changed the title. 😅
There seems to be a misunderstanding here.

You need to include the term Fixes #3567 in your first comment rather than in the headline.

So the line Fix for #3567. in the initial comment should be changed to Fixes #3567..

It has not to be the first line though.

kind regards

@igiannakas
Copy link
Contributor Author

@igiannakas Sorry, I did not get right away why you changed the title. 😅 There seems to be a misunderstanding here.

You need to include the term Fixes #3567 in your first comment rather than in the headline.

So the line Fix for #3567. in the initial comment should be changed to Fixes #3567..

It has not to be the first line though.

kind regards

Ah silly me! Thank you!

@discip
Copy link
Contributor

discip commented Jan 11, 2024

No problem.
You are welcome! 😃👍

@igiannakas igiannakas changed the title Fixes #3567 - Lightning infill with sparse infill width set to 0 causes "divide by zero" fatal error [Bug fix] Fixes Lightning infill with sparse infill width set to 0 causes "divide by zero" fatal error Jan 12, 2024
@igiannakas igiannakas changed the title [Bug fix] Fixes Lightning infill with sparse infill width set to 0 causes "divide by zero" fatal error [Bug fix] Fixes lightning infill with sparse infill width set to 0 causes "divide by zero" fatal error Jan 12, 2024
…ill-with-sparse-infill-width-set-to-0-causes-divide-by-zero-fatal-error
…parse-infill-width-set-to-0-causes-divide-by-zero-fatal-error
Copy link
Owner

@SoftFever SoftFever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Thanks man!

@SoftFever SoftFever merged commit a996188 into SoftFever:main Jan 14, 2024
12 checks passed
@igiannakas igiannakas deleted the Fix-#3567---Lightning-infill-with-sparse-infill-width-set-to-0-causes-divide-by-zero-fatal-error branch January 14, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lightning infill with sparse infill width set to 0 causes "divide by zero" fatal error
3 participants