Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified filaments/process/starting codes and added a new print layer height 0.16mm in the process #4200

Merged
merged 33 commits into from
Mar 1, 2024

Conversation

InfimechOfficial
Copy link
Contributor

No description provided.

@InfimechOfficial InfimechOfficial changed the title Modified filament是、/process/starting codes and added new print layer heights Modified filaments/process/starting codes and added new print layer heights Feb 23, 2024
@InfimechOfficial
Copy link
Contributor Author

Hello, this time I modified more files, if these files are conflicting, please detail the reason for the conflicts, I will modify these files,thank you!

@InfimechOfficial InfimechOfficial changed the title Modified filaments/process/starting codes and added new print layer heights Modified filaments/process/starting codes and added a new print layer height 0.16mm in the process Feb 23, 2024
@InfimechOfficial
Copy link
Contributor Author

Hello, are there some conflicts?

@SoftFever
Copy link
Owner

You can check if there are conflicts by yourself.
There will be warnings in this area if there conflicts,
image

@InfimechOfficial InfimechOfficial marked this pull request as ready for review February 25, 2024 13:21
@InfimechOfficial
Copy link
Contributor Author

Hi I clicked the Update branch button, and do not notice any conflicts here

@InfimechOfficial
Copy link
Contributor Author

Hi, I hope I can see the fixed parameters in the new version, Could it catch up?

@SoftFever
Copy link
Owner

@InfimechOfficial There are errors in your changes that prevent Orca loading the profiles properly.
Can you take a look?

Meanwhile, I have created a tool to help validate profiles locally.
Please take a look here, that should help you find errors easier:
https://github.com/SoftFever/Orca_tools/releases/tag/1

@InfimechOfficial
Copy link
Contributor Author

thanks for your help I will try it

@InfimechOfficial
Copy link
Contributor Author

Hi, I fixed the conflics and checked profiles by Validator that you creatived, I also downloaded the profiles what I fixed and put it in my orcaslicer, Orcaslicer software can show my printer well. But I noticed that there are two error message displayed,
Are there still any mistakes here?

@SoftFever
Copy link
Owner

Hi, I fixed the conflics and checked profiles by Validator that you creatived, I also downloaded the profiles what I fixed and put it in my orcaslicer, Orcaslicer software can show my printer well. But I noticed that there are two error message displayed, Are there still any mistakes here?

the CI/CD shows no errors.
What error message did you see?

@InfimechOfficial
Copy link
Contributor Author

Hi, I fixed the conflics and checked profiles by Validator that you creatived, I also downloaded the profiles what I fixed and put it in my orcaslicer, Orcaslicer software can show my printer well. But I noticed that there are two error message displayed, Are there still any mistakes here?

the CI/CD shows no errors. What error message did you see?

I saw two red checkmarks on it and thought it was two error messages, if not, there should be no error here

Copy link
Owner

@SoftFever SoftFever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks

@SoftFever SoftFever merged commit ad9779f into SoftFever:main Mar 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants