Allow AppImage generation in aarch64 build hosts #4410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodriguezst
force-pushed
the
rodriguezst-appimage-aarch64
branch
from
1e569af to
a7c965b
Compare
It was harcoded to x86_64 and was failing to generate AppImage files on aarch64 build hosts
rodriguezst
force-pushed
the
rodriguezst-appimage-aarch64
branch
from
a7c965b to
b405a44
Compare
nevack
reviewed
Mar 13, 2024
| @@ -1,5 +1,5 @@ | |||
| #!/bin/sh | |||
| APPIMAGETOOLURL="https://github.com/AppImage/AppImageKit/releases/latest/download/appimagetool-x86_64.AppImage" | |||
| APPIMAGETOOLURL="https://github.com/AppImage/AppImageKit/releases/latest/download/appimagetool-$(uname -m).AppImage" | |||
There was a problem hiding this comment.
nit: Maybe move it to var to not repeat yourself?
#!/bin/sh
APPIMAGETOOLARCH="$(uname -m)"
APPIMAGETOOLURL="https://github.com/AppImage/AppImageKit/releases/latest/download/appimagetool-${APPIMAGETOOLARCH}.AppImage"
...
mv "@SLIC3R_APP_KEY@-${APPIMAGETOOLARCH}.AppImage" "${APP_IMAGE}"
chmod +x "${APP_IMAGE}"
There was a problem hiding this comment.
Good suggestion.
But since it's only used in two places, it's fine ;)
|
Thank you very much for this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AppImageTool no longer hardcoded to x86_64 to allow generation of AppImage files on aarch64 build hosts