Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lowering wipe tower margin #4661

Merged
merged 8 commits into from
Apr 3, 2024
Merged

Lowering wipe tower margin #4661

merged 8 commits into from
Apr 3, 2024

Conversation

vgdh
Copy link
Contributor

@vgdh vgdh commented Mar 23, 2024 •
edited
Loading

Fix the issue #2824 . Lowered too big wipe tower margin.
Was.
1
Now:
Снимок

colabliondev
colabliondev approved these changes Mar 24, 2024
View reviewed changes
Copy link

@colabliondev colabliondev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works. 👍

@vgdh vgdh changed the title lower wipe tower margin Lowering wipe tower margin Mar 25, 2024
CristianGTR97
CristianGTR97 approved these changes Mar 31, 2024
View reviewed changes
Copy link

@CristianGTR97 CristianGTR97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IT WORKS WELL. PLEASE APPROVE THIS

@vgdh
Copy link
Contributor Author

vgdh commented Mar 31, 2024

IT WORKS WELL. PLEASE APPROVE THIS

@SoftFever can you merge this PR?

@SoftFever
Copy link
Owner

If the brim for tower is enabled, it will increase the chance of generating gcode outside of the bed.
Considering there is a gcode boundary check, this change looks fine and acceptable to me.

Thank you.

@SoftFever SoftFever merged commit 3f411e2 into SoftFever:main Apr 3, 2024
powpingdone pushed a commit to powpingdone/OrcaSlicer that referenced this pull request Apr 10, 2024
@vgdh @powpingdone
Lowering wipe tower margin (SoftFever#4661)
c609fb9 
lower wipe tower margin
powpingdone pushed a commit to powpingdone/OrcaSlicer that referenced this pull request Apr 11, 2024
@vgdh @powpingdone
Lowering wipe tower margin (SoftFever#4661)
4f3129e 
lower wipe tower margin
SoftFever pushed a commit that referenced this pull request Apr 13, 2024
@vgdh @SoftFever
Lowering wipe tower margin (#4661)
1ed3530 
lower wipe tower margin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CristianGTR97 CristianGTR97 CristianGTR97 approved these changes

@SoftFever SoftFever SoftFever approved these changes

@colabliondev colabliondev colabliondev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vgdh @SoftFever @CristianGTR97 @colabliondev