Wrong bridge detection result (FOR TESTING ONLY)

[SoftFever]

Quick and dirty.
Haven't got time to dive deep to the original code logic yet.
Initial testing result seems fine.

@igiannakas
OrcaCube.zip

[igiannakas]

Makes sense, subtract top area from the bridging area, good one! The only thing I can think off is whether we need to add an expansion margin to the top area unless that is covered elsewhere? To ensure there is enough expansion basically underneath the solid infill lines above the Z.

Will also need to regression test it with the sloped models to make sure bridging is still performed properly there.

Will test a bit when back home.

[SoftFever]

Yeah, bridge margin is usually handled in perimeter generator

[igiannakas]

Initial tests show no regressions. Sloped surfaces look good, no impact there. Standard models look also OK.

To contain potential impact for defects in the 2.0 release, maybe push this in 2.1 after more testing by the community?

I've merged it in my dev branch and use it as my daily just in case any issues pop up :)

[SoftFever]

Initial tests show no regressions. Sloped surfaces look good, no impact there. Standard models look also OK.

To contain potential impact for defects in the 2.0 release, maybe push this in 2.1 after more testing by the community?

I've merged it in my dev branch and use it as my daily just in case any issues pop up :)

I think so, too

[vgdh]

something maybe wrong
sudden flow change in the bridge


Cube.zip

[igiannakas]

something maybe wrong sudden flow change in the bridge Cube.zip

Is this also happening with the 2.0 release or not?

[vgdh]

same behavior

[igiannakas]

So it’s not this PR then, right?

[vgdh]

So it’s not this PR then, right?

yeah