-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix segmentation fault when running CLI #4702
Conversation
I'm not fluent in cpp, but having a working cli again is a huge thing for my project. Either if it's merged or not @asokawotulo thanks for making this PR! |
Happy I could help @grepson! Out of curiosity, what's the project you're working on and how do you use the CLI? |
@asokawotulo I'm using it to remotely slice prints into gcodes for different printers. I have already completed workflows for PrusaSlicer, SuperSlicer, Cura and thanks to this PR maybe I'll be able to add OrcaSlicer to that ❤️! I have an API written in Typescript that takes some body params and stl to slice, fires up docker container underneath and slices that file. |
@grepson Ohh interesting I'm actually also working on a similar project to remotely slice files, but with just OrcaSlicer since I only have a Bambu printer I probably could have used Bambu Studio's CLI since that was working when I tested it, but I preferred the idea of using OrcaSlicer. Plus refreshing my C++ skills was a nice bonus |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Thank you
* fix: replace extruder_clearance_max_radius with extruder_clearance_radius * fix: add if m_plater before accessing preset_bundle * fix: generate thumbnail only when callback is defined * fix: change default gcode thumbnail format to png
* fix: replace extruder_clearance_max_radius with extruder_clearance_radius * fix: add if m_plater before accessing preset_bundle * fix: generate thumbnail only when callback is defined * fix: change default gcode thumbnail format to png
* fix: replace extruder_clearance_max_radius with extruder_clearance_radius * fix: add if m_plater before accessing preset_bundle * fix: generate thumbnail only when callback is defined * fix: change default gcode thumbnail format to png
Fixes: #1194
Changes:
extruder_clearance_max_radius
withextruder_clearance_radius
to resolve the CLI errorif (m_plater)
before accessing preset_bundle ingenerate_logo_polygon
and beforegenerate_plate_name_texture