-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjustable infill wall overlap for top and bottom surfaces #4832
Adjustable infill wall overlap for top and bottom surfaces #4832
Conversation
it can be a smooth transition with function of an S-curve from bottom to the top: |
What the aim here is actually the opposite - lower overlap in the infill as you only need it to adhere the solid and sparse infill to the perimeters (so 10-15% overlap is plenty for that) and then go 25-30% or more on the top surfaces to cover any gaps due to the extrusion width. A curve is an interesting approach, will experiment with it. the background to this Pr is I’m printing some ERCF parts and noticing some slight gapping on the top solid infill (pinholes) but increasing the previous overlap would cause over extrusion on the top surface. |
…-top-and-bottom-surfaces
…-top-and-bottom-surfaces
…-top-and-bottom-surfaces
…-top-and-bottom-surfaces
…-top-and-bottom-surfaces
…-top-and-bottom-surfaces
…-top-and-bottom-surfaces
…-top-and-bottom-surfaces
…-top-and-bottom-surfaces
…-top-and-bottom-surfaces
Just wanted to give an update on testing this - have been using it for the past month or so daily when printing my stealthmax, ERCF components and others. So far from my testing it works ok and nothing appears broken - however my testing was exclusively on Arachne. if anyone can test this using classic it would be much appreciated. in terms of quality benefits it has benefited greatly especially with models where the top surface is printed at a steep angle compared to the external walls. There having a higher overlap leads to less pinholes while also allowing less over extrusion to come through from the layers below that are set to less overlap. (Last picture). |
…-top-and-bottom-surfaces
…all-overlap-for-top-and-bottom-surfaces
…all-overlap-for-top-and-bottom-surfaces
…-top-and-bottom-surfaces
…-top-and-bottom-surfaces
Thanks. |
Fully agree!! I’ve found the best success with a large overlap on top and bottom surface - 30%+ and very little overlap for internal infill - 5-10% just to get enough bonding with the walls without causing over extrusion. Have been pretty successful with the above PR since raising it, with around 1k print hours on the Voron 😀 so thank you for merging this 🙏🏻🙏🏻 |
Love the implementation of this feature. Thank you! I did notice that the "Rectilinear" infill only runs in one direction. Similar to aligned rectilinear. Maybe a bug? |
This PR allows for independent adjustment of the infill/wall overlap for internal solid and sparse infill and top and bottom surfaces.
Benefits:
Before you could adjust the overlap as a global value attempting to find a compromise between slight pinholes on the top surface and not too much material build up where the nozzle met the walls in the internal solid infill. Now these can be adjusted separately so you can get the best of both worlds:
Images:
Before:
![image](https://private-user-images.githubusercontent.com/59056762/318403954-9716f56e-2d96-4534-af2c-2a8c9e1f0dfa.jpeg?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1NzAwMDMsIm5iZiI6MTczOTU2OTcwMywicGF0aCI6Ii81OTA1Njc2Mi8zMTg0MDM5NTQtOTcxNmY1NmUtMmQ5Ni00NTM0LWFmMmMtMmE4YzllMWYwZGZhLmpwZWc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjE0JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxNFQyMTQ4MjNaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT02YjY2ZmM3ZGNkYTMxYTAwNGFjM2Q0YTRjNmYwMjgwMjMzNDY2M2IxM2VjYmEzMTZjNzEyNGQyMzQ2ZDYyYWVhJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.lMzCUtrfmH2OgZRFKhlqkfkkTpqw8FIIckgzvP0paFs)
30% overlap is a good value to use to have no top surface pockmarks.
However this results in excessive overlap between internal walls and solid infill causing build up of material especially if many top/bottom surface layers exist
![image](https://private-user-images.githubusercontent.com/59056762/318403703-add5160a-8653-4772-b0d1-e101b52a7daa.jpeg?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1NzAwMDMsIm5iZiI6MTczOTU2OTcwMywicGF0aCI6Ii81OTA1Njc2Mi8zMTg0MDM3MDMtYWRkNTE2MGEtODY1My00NzcyLWIwZDEtZTEwMWI1MmE3ZGFhLmpwZWc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjE0JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxNFQyMTQ4MjNaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT00ZmI1MjMxYmJmYzk5NjA1MTBhZDkxNmI1ZTFiYzUxZmNjYTRhMGMwMzhkYzhjOTc4NzgzNzg5ODZiNGJmMGRjJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.9dmjQlfT25MV5vSJC8rvHGkUUBgTJaZyNFFIXYGCS7Q)
After:
![image](https://private-user-images.githubusercontent.com/59056762/318407645-22d86e58-dde7-48d8-975c-a6621b693d82.jpeg?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1NzAwMDMsIm5iZiI6MTczOTU2OTcwMywicGF0aCI6Ii81OTA1Njc2Mi8zMTg0MDc2NDUtMjJkODZlNTgtZGRlNy00OGQ4LTk3NWMtYTY2MjFiNjkzZDgyLmpwZWc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjE0JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxNFQyMTQ4MjNaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0wNjIxNmE0ZjI5MGI4MWVjNWMxM2U1NDY3MmYwNGFlNDFjYzNiZmQ3ZThmMGNhNzFhMmQ4Y2Y4MWY4MjEwYmY4JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.VAN7NoED0pndDNEORE95ny6JZVTu0e0fRXTdqxvfUqg)
Top surface at 30% - no pinholes
Infill set to 0% (for demonstration purposes) - reduced over extrusion.
![image](https://private-user-images.githubusercontent.com/59056762/318408433-bc46402d-1d04-4381-8844-259bee8aa191.jpeg?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1NzAwMDMsIm5iZiI6MTczOTU2OTcwMywicGF0aCI6Ii81OTA1Njc2Mi8zMTg0MDg0MzMtYmM0NjQwMmQtMWQwNC00MzgxLTg4NDQtMjU5YmVlOGFhMTkxLmpwZWc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjE0JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxNFQyMTQ4MjNaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1mYjQ5ZjBhMjEzYjJhNWYwMjhhZWQ5NTU5YzlhOGI5MjQ2YzdiMDRkNWYwMGIwMWQyNGU0ZTRkNGNmMzUzMDIwJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.04sBVKKjRl5YszCVvxetxQqLX1b-SfLYcMBtxVSM6iM)
From Ellis' print tuning website:
When overlap is set too low
![](https://camo.githubusercontent.com/47c2a066e1bf69f43e388fcd7bb0178e5c4c0dab3c602fdd386405b653a7cd03/68747470733a2f2f656c6c69733364702e636f6d2f5072696e742d54756e696e672d47756964652f61727469636c65732f696d616765732f696e66696c6c5f706572696d657465725f6f7665726c61702f4f7665726c61702d312e706e67)
We can see slight pinholes on the top surface.
Here you can see that a lower overlap results in a cleaner top surface, with slight gaps appearing around the hexagon. A higher overlap is creating slight over extrusion at the edges of the model due to the over extrusion in the layers below due to material accumulation but the gaps on the hexagon are gone.
By allowing an independent setting of these two variables, a large top layer overlap can be set without creating over extrusion.
Notes:
This is still in testing from my side - seeking for feedback as I am not 100% familiar with the affected code segments in the perimeter generator and may have made a mistake that results in edge case issues.
The previous value from any user presets are carried over and used for the infill overlap - the top overlap is set to a default of 25% as good default to minimise top surface pinholes as per Ellis' recommendations.
The overlap variables are now assigned to their corresponding section in the UI - top and bottom shells contains the top and bottom overlap and infill contains the infill overlap.