-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port of Cura's multi-material interlocking #5775
Conversation
Nice!! |
@@ -2810,6 +2810,56 @@ void PrintConfigDef::init_fff_params() | |||
def->mode = comAdvanced; | |||
def->set_default_value(new ConfigOptionFloat(0.)); | |||
|
|||
def = this->add("interlocking_beam", coBool); | |||
def->label = L("Use beam interlocking"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would it be better to use "Generate interlocking structure" here? Same as Cura.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because there is already some type of interlocking in Orca, by generating overlapping layers. hens this option as a different type of interlocking.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Could you please add (Assembled) to the tooltip (mouse over) |
Ported from Cura. Huge thanks for their greate work!
Unlike the interlocking currently presents in Orca that only applys to painted multi-color, this new interlocking structure works with filament modifiers too:
![image](https://private-user-images.githubusercontent.com/1537155/341669929-66959189-eea4-4e25-975a-1cf0ffb03594.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1NjkzNzUsIm5iZiI6MTczOTU2OTA3NSwicGF0aCI6Ii8xNTM3MTU1LzM0MTY2OTkyOS02Njk1OTE4OS1lZWE0LTRlMjUtOTc1YS0xY2YwZmZiMDM1OTQucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxNCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTRUMjEzNzU1WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NzFkZTE1ZDM2NzZhYzdkZTZjOTJjNGUxYTkyYTFmZDcxMWQ5NWUzMmFkY2Q3ZjY0ZTE4Y2JiNWE3OGRjODRiOCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.QdbUF9suwVDwH273cQK6QJzCwNTYPcyrfW4cQ5Y1co0)
![image](https://private-user-images.githubusercontent.com/1537155/341670110-76d85b8d-caac-47ea-8c2c-56217ffd7826.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1NjkzNzUsIm5iZiI6MTczOTU2OTA3NSwicGF0aCI6Ii8xNTM3MTU1LzM0MTY3MDExMC03NmQ4NWI4ZC1jYWFjLTQ3ZWEtOGMyYy01NjIxN2ZmZDc4MjYucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxNCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTRUMjEzNzU1WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ZWQ3ZGJkMTllZWJmYjU1ZTdkNGUzNWVmZjQ3OWY4ZmQ0OWUzY2I5YjU5NzY4N2I1MjkxYmRmMzVmZTY5OTllMSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.PwemsI56Z3UkKY4TIFQ62huEDP-53t1ByJleZyBgxgA)
![image](https://private-user-images.githubusercontent.com/1537155/341669978-c1c594a3-4f32-4871-b999-e2bfb625f944.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk1NjkzNzUsIm5iZiI6MTczOTU2OTA3NSwicGF0aCI6Ii8xNTM3MTU1LzM0MTY2OTk3OC1jMWM1OTRhMy00ZjMyLTQ4NzEtYjk5OS1lMmJmYjYyNWY5NDQucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxNCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTRUMjEzNzU1WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ODdlYWExM2RhNmIzYmMzMmQzMTdhNjVhYzhmYjZiYzhlZDY4YmVmN2NmZGNkMmUwOTkwMDc4NDY5N2VjNWMxZiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.VHrQluH-iwEMHzrckTKJIHU6tPnfMYIppo2be0a9Xws)
Old:
New: