Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port of Cura's multi-material interlocking #5775

Merged
merged 7 commits into from
Jun 30, 2024

Conversation

Noisyfox
Copy link
Collaborator

@Noisyfox Noisyfox commented Jun 20, 2024

interlocking

Ported from Cura. Huge thanks for their greate work!

Unlike the interlocking currently presents in Orca that only applys to painted multi-color, this new interlocking structure works with filament modifiers too:
image
Old:
image
New:
image

@igiannakas
Copy link
Contributor

Nice!!

@Noisyfox Noisyfox marked this pull request as ready for review June 21, 2024 06:51
@Noisyfox
Copy link
Collaborator Author

c2db2a979549678d70fb3aa302414c44
Black: PETG white: PLA

Very strong bounding.

@@ -2810,6 +2810,56 @@ void PrintConfigDef::init_fff_params()
def->mode = comAdvanced;
def->set_default_value(new ConfigOptionFloat(0.));

def = this->add("interlocking_beam", coBool);
def->label = L("Use beam interlocking");
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it be better to use "Generate interlocking structure" here? Same as Cura.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because there is already some type of interlocking in Orca, by generating overlapping layers. hens this option as a different type of interlocking.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see

Copy link
Owner

@SoftFever SoftFever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@SoftFever SoftFever merged commit 4145f45 into SoftFever:main Jun 30, 2024
12 checks passed
@ingoiot
Copy link

ingoiot commented Jan 13, 2025

Could you please add (Assembled) to the tooltip (mouse over)
I always wonder why this does nothing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants