Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Web Link Association in Preferences #5791

Merged
merged 5 commits into from
Jun 21, 2024

Conversation

Ocraftyone
Copy link
Contributor

@Ocraftyone Ocraftyone commented Jun 21, 2024

Description

This PR updates the visuals of the "Associate web links to OrcaSlicer" section of the preferences dialog

It replaces the old buttons with check boxes that clearly show if the current instance has already been registered. The part that shows the path the the currently registered instance has also been reworked.

Screenshots/Recordings/Graphs

image

Tests

Tested on Windows

Ocraftyone and others added 5 commits June 21, 2024 01:35
Uses a checkbox in place of button to show if the current instance is registered at a quick look
New function is added to build the link association item
Current association line shows "None" for no app associated, "Current Instance" if the current instance is associated, and the formatted path to the registered app (Removes quotes and other extra chars)
Copy link
Owner

@SoftFever SoftFever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good
Thank you

@SoftFever SoftFever merged commit 5c9b82d into SoftFever:main Jun 21, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants