Allow printing prohibited filaments when 'Skip AMS Blacklist Check' is enabled #7161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow printing prohibited filaments when 'Skip AMS Blacklist Check' is enabled.
Until now for prohibited filaments (even with Skip Check enabled) you get a warning and when clicking on 'Confirm' nothing happens. If using the 'Send' instead of 'Printing' it sends it fine to the printer as no check is performed but the print has to be started manually at the printer.
The PR checks if 'Skip AMS Blacklist Check' is enabled and overwrites the prohibit action from the blacklist file while the check is running with a warning action, so there is still a popup window but when confirming the print actually starts.
This is for sure not the most beautiful solution but the least intrusive as everything stays the same for the standard case where 'Skip AMS Blacklist Check' is disabled (default).
Screenshots/Recordings/Graphs
No UI changes were made.
Tests
Compiled and tested in my Repo, verified working on Windows 11 with 'Skip AMS Blacklist Check' enabled and disabled.