Fixed double-label for fan speed-up time, fixed label to include hyphen #996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
no empty L("") are allowed or remove L and fix empty label bug in src/libslic3r/PrintConfig.cpp def->label = L(""); <-- no pot file was created with this cpp input L("") not possible you can test it and get a error xgettext --keyword=L --keyword=_L --keyword=_u8L --keyword=L_CONTEXT:1,2c --keyword=_L_PLURAL:1,2 --add-comments=TRN --from-code=UTF-8 --no-location --debug --boost -f "bbl/i18n/list.txt" -o "bbl/i18n/OrcaSlicer.pot" |
SoftFever
requested changes
May 8, 2023
scottmudge
force-pushed
the
bugfix_double_fanspeed_label
branch
from
b8dd4cf to
eafe696
Compare
|
Should be fixed now -- thought it needed a string object in label, but good to know it can be left unset. Don't use translations, so didn't catch that. Thanks! |
fr3ak2402
pushed a commit
to fr3ak2402/OrcaSlicer
that referenced
this pull request
May 8, 2023
…en (SoftFever#996) Fixed double-label for fan speed-up time, fixed label to include hyphen.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor change to correct double "Fan speedup time" label (now only included in the
Lineobject), and add hyphen to "speed-up", which should be the correct spelling.