generated from SoftwareBrothers/adminjs-feature-template
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Authentication is broken in v4.0.0 #13
Comments
I did some further investigation. The condition |
camanjj
added a commit
to camanjj/adminjs-fastify
that referenced
this issue
Jun 5, 2023
Issue is outlined in SoftwareBrothers#13
dziraf
pushed a commit
that referenced
this issue
Jun 30, 2023
* Fix issue with Authentication not leading to login page Issue is outlined in #13 * fix: add missing parentheses * Update protected-routes.handler.ts Fixes Typescript error for optional `Object`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In the latest commit in
protected-routes.handler.ts
the following else if block was introduced:It breaks authentication and AdminJS is accessible without login. After removing it everything works as expected again. A minimal installation following the docs is enough to reproduce the issue.
The text was updated successfully, but these errors were encountered: