-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose playback_rate to AudioFileSettings #20
Labels
Feature
New additions to the API surface
Comments
Yeah that is would be a pretty small PR to implement -- expose the value, and integrate it in the settings structs when creating the asset. |
I already have the changes locally and I’ve been using them. It seems a pretty tiny change. I’ll make the PR when I get a chance. Hopefully I can also update an example or add one if it’s appropriate. |
SolarLiner
added a commit
that referenced
this issue
Jun 19, 2024
Fixes #20 As with `volume`, only support fixed playback rates and so just expose it as an f64/`Fixed`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Summary
playback_rate
exists in:https://github.com/tesselode/kira/blob/ed69848baf290c2def2b58412b4b0a035c435fd7/crates/kira/src/sound/static_sound/settings.rs#L24
And in:
https://github.com/tesselode/kira/blob/ed69848baf290c2def2b58412b4b0a035c435fd7/crates/kira/src/sound/streaming/settings.rs#L22
But there's no way to set it in
bevy-kira-components
.Implementation proposal
Expose it in
AudioFileSettings
:As with
volume
, just support fixed and so expose it as an f64/Fixed
.Callers could then do this:
Looks like a pretty tiny PR unless I'm missing something, let me know if you're happy with this approach and I can submit it.
The text was updated successfully, but these errors were encountered: