Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AudioFileHandle::toggle convenience method #14

Merged
merged 2 commits into from
May 8, 2024
Merged

Add AudioFileHandle::toggle convenience method #14

merged 2 commits into from
May 8, 2024

Conversation

SolarLiner
Copy link
Owner

Closes #4

Description

Adds a AudioFileHandle::toggle method for convenience.

@SolarLiner SolarLiner added the Feature New additions to the API surface label May 6, 2024
@SolarLiner SolarLiner changed the title fix/04 Add AudioFileHandle::toggle convenience method May 6, 2024
GitGhillie
GitGhillie approved these changes May 6, 2024
View reviewed changes
Copy link
Collaborator

@GitGhillie GitGhillie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might as well use it in the audio_control example but could also be a follow-up PR. LGTM

src/sources/audio_file/source.rs Show resolved Hide resolved
@SolarLiner SolarLiner merged commit 1932421 into main May 8, 2024
4 checks passed
@SolarLiner SolarLiner deleted the fix/04 branch May 8, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GitGhillie GitGhillie GitGhillie approved these changes

Assignees
No one assigned
Labels
Feature New additions to the API surface
Projects
Bevy Audio v2 PRs
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing .toggle() functionality
2 participants
@SolarLiner @GitGhillie