Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use linear attenuation in SpatialEmitter by default #8

Merged
merged 2 commits into from
May 5, 2024
Merged

fix: use linear attenuation in SpatialEmitter by default #8

merged 2 commits into from
May 5, 2024

Conversation

mgi388
Copy link
Contributor

@mgi388 mgi388 commented May 5, 2024

Description

  • I noticed the spatial example didn't change volume as you moved the camera away from the sphere
  • This is because the default for SpatialEmitter didn't set an attenuation
  • With this change, the defaults are what users expect (as I expected), and also match Kira's default
  • See Discord messages for the original report

Testing

  • Ran the spatial example and observed the sound diminish as I moved the camera away from the sphere, and observed the sound come back in as I moved the camera back towards the sphere

@SolarLiner SolarLiner added the Examples Changes affecting the provided examples label May 5, 2024
SolarLiner
SolarLiner approved these changes May 5, 2024
View reviewed changes
Copy link
Owner

@SolarLiner SolarLiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

src/spatial.rs Outdated Show resolved Hide resolved
@SolarLiner SolarLiner added this to the 0.2 milestone May 5, 2024
mgi388 and others added 2 commits May 5, 2024 23:51
@SolarLiner SolarLiner force-pushed the linear-attenuation-default branch from d0ceb2e to 00be819 Compare May 5, 2024 21:51
@SolarLiner SolarLiner merged commit ad090ad into SolarLiner:main May 5, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SolarLiner SolarLiner SolarLiner approved these changes

Assignees
No one assigned
Labels
Examples Changes affecting the provided examples
Projects
Bevy Audio v2 PRs
Status: Done
Milestone
0.2
Development

Successfully merging this pull request may close these issues.
2 participants
@mgi388 @SolarLiner