Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Highlight Script #37

Merged
merged 28 commits into from
Dec 11, 2024
Merged

Update to Highlight Script #37

merged 28 commits into from
Dec 11, 2024

Conversation

Rework-Digital
Copy link
Contributor

Additional features added to highlight script.

@@ -1,23 +1,23 @@
@import url(./splide-core.min.css);
@import url(https://solcast.github.io/static/assets/css/splide-core.min.css);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Rework-Digital this will 100% stop working after we update the CSP header policy - relative URLs will work because they come from the same domain

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't relative links also fail as they will be looking in solcast.com or solcast.io domains rather then the github repo?

@alex-solcast alex-solcast merged commit 62f0fb4 into Solcast:main Dec 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants