Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alpha Release v0.1.0 #64

Merged
merged 288 commits into from
Oct 1, 2022
Merged

Alpha Release v0.1.0 #64

merged 288 commits into from
Oct 1, 2022

Conversation

SiegeToaster
Copy link
Member

No description provided.

Liam McKendrick and others added 30 commits June 28, 2022 02:12
orbat updates:
- added HEX code definitions for better code readability
- Update function description and fix example
- check briefOrbat before executing
- whitespace removal/addition where necessary
- changed string addition to joinString (see https://community.bistudio.com/wiki/Code_Optimisation#Concatenating_multiple_small_strings_together)
- fix refresh execution
- renamed to proper format

Cspell additions:
"Koromiko" - color
"QFUNC" - macro
giveRadios fix function call
orbat fix variables
…before executing giveRadios

PREP should be alphebetized so that it is easier to read and compare it to the file explorer.
ACRE shouldn't need to be checked in individual functions, just the handler.  But it doesn't hurt (about 1.25ms exec time) to have some redundancy.
hint:
- macro usage
- haveKATMedical is a config value
- whitespace
- semicolon at end of command

teleport to squad: update example
handlers module removed because of lack of need
acre and tfar modules merged into radios module
kat and ctab modules merged into misc_items module
https://discord.com/channels/689674061366034435/966070504060489788/992215410357321829
* acreRadioSetup add function and header

* finish acreRadioSetup port
for example, a shortcut to .rpt logs
create composition (doesn't work properly)
fix SET_CONFIG macro
- change "SCALAR" type to "Integer"
- add default value column
@L-McKendrick
Copy link
Contributor

L-McKendrick commented Sep 28, 2022

There seems to be an issue with the Role Editor arsenal editor

RPT
14:33:41   Error position: <select (_category - 5);
};
};


private >
14:33:41   Error Zero divisor
14:33:41 File z\sia3f\addons\configuration\functions\fnc_additionalItemsAddItems.sqf..., line 70
14:33:41 [SIA3F] (configuration) TRACE: 27221 additionalItemsCategory params: _index=14 z\sia3f\addons\configuration\functions\fnc_additionalItemsCategory.sqf:20
14:33:41 Error in expression <ategory - 3);
};
default {
_configItems select (_category - 5);
};
};


private >
14:33:41   Error position: <select (_category - 5);
};
};


private >
14:33:41   Error Zero divisor
14:33:41 File z\sia3f\addons\configuration\functions\fnc_additionalItemsAddItems.sqf..., line 70
14:33:41 [SIA3F] (configuration) TRACE: 27241 additionalItemsCategory params: _index=17 z\sia3f\addons\configuration\functions\fnc_additionalItemsCategory.sqf:20
14:33:41 Error in expression <ategory - 3);
};
default {
_configItems select (_category - 5);
};
};


private >
14:33:41   Error position: <select (_category - 5);
};
};

@SiegeToaster SiegeToaster marked this pull request as ready for review October 1, 2022 02:06
@SiegeToaster
Copy link
Member Author

Merging before this is ready in order to meet September 30 deadline.
A lesson was learned: It takes more than 2 days that are already quite busy to review thousands of lines of code.

@SiegeToaster SiegeToaster merged commit ae9f75e into release Oct 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants