Catch potential WebExceptions when retrieving CC.NET builds

Soloplan · Feb 11, 2020 · 5890655 · 5890655
1 parent ed1c92c
commit 5890655
Showing 1 changed file with 18 additions and 11 deletions.
diff --git a/src/Soloplan.WhatsON.CruiseControl/CruiseControlServer.cs b/src/Soloplan.WhatsON.CruiseControl/CruiseControlServer.cs
@@ -56,20 +56,27 @@ public async Task<List<CruiseControlBuild>> GetBuilds(string projectName, int li
       var projectReportUrl = UrlHelper.GetAllBuildsUrl(this.baseUrl, projectName);
       using (var client = new WebClient())
       {
-        var html = client.DownloadString(projectReportUrl);
-        var doc = new HtmlDocument();
-        doc.LoadHtml(html);
-        var recentBuilds = doc.DocumentNode.SelectNodes("//table[@class='RecentBuildsPanel']/tr/td/a[@class]");
-        foreach (var b in recentBuilds.Take(limit))
+        try
         {
-          var authority = new Uri(projectReportUrl).GetLeftPart(System.UriPartial.Authority);
-          var build = CruiseControlBuild.FromHtmlNode(b, authority);
-          if (build == null)
+          var html = client.DownloadString(projectReportUrl);
+          var doc = new HtmlDocument();
+          doc.LoadHtml(html);
+          var recentBuilds = doc.DocumentNode.SelectNodes("//table[@class='RecentBuildsPanel']/tr/td/a[@class]");
+          foreach (var b in recentBuilds.Take(limit))
           {
-            continue;
+            var authority = new Uri(projectReportUrl).GetLeftPart(System.UriPartial.Authority);
+            var build = CruiseControlBuild.FromHtmlNode(b, authority);
+            if (build == null)
+            {
+              continue;
+            }
+
+            history.Add(build);
           }
-
-          history.Add(build);
+        }
+        catch (WebException ex)
+        {
+          log.Error(ex);
         }
       }