Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance when opening the application from tray #10

Closed
steffen-wilke opened this issue Dec 18, 2019 · 4 comments
Closed

Improve performance when opening the application from tray #10

steffen-wilke opened this issue Dec 18, 2019 · 4 comments
Assignees
Labels
enhancement New feature or request Priority: High

Comments

@steffen-wilke
Copy link
Member

When opening the tool from the tray icon, currently the application re-initializes itself completely.
This causes a major performance issue on an operation that is intended to be quick and seamless.

We need to prevent this and make sure that the application keeps its state even though it is minimized to the tray.

@steffen-wilke steffen-wilke added the enhancement New feature or request label Dec 18, 2019
@krzysztof-lorenc
Copy link
Collaborator

I'm not sure if that is actually a problem. For example, new versions of Skype works also exactly that way.
The benefit of this is lower memory consumption, assuming that we free the memory correctly.

@steffen-wilke
Copy link
Member Author

It is a problem. Depending on the configuration, it takes up multiple seconds for the application to even show up. For a tool that is intended to provide a quick overview, this is a major UX issue.

@dominikgolda
Copy link
Collaborator

I tried using VirtualizingStackPanel.IsVirtualizing="True" in ConnectorsTreeView.mainTreeView. It improves show performance, but it has some side effects.

  1. If you have partially visible expanded group - like on screenshot below - the app will eat lot of CPU. I doesn't happen in simple app, but it my be difficult to find what we are doing wrong.
    2020-01-17_11h36_54
  2. Improvement is strongly dependent on how many projects are visible on screen. If all are visible at once then there is no difference.
  3. Sometimes when opening/closing/opening window fast exception is thrown. See here. I haven't found 100% working solution for this.

@dominikgolda
Copy link
Collaborator

We no longer close the window when it is minimized to tray.

steffen-wilke added a commit that referenced this issue Feb 10, 2020
Similar to the TrayHandler, it should also just be hidden instead of being closed to prevent a full UI reload upon the next opening of the application.

Issue #10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Priority: High
Projects
None yet
Development

No branches or pull requests

3 participants