Adds support for custom identity resources and claims #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @AleF83, |
AleF83
requested changes
Aug 21, 2019
src/utils/ClaimJsonConverter.cs
Outdated
|
|
||
| namespace OpenIdConnectServer.Utils | ||
| { | ||
| public class ClaimJsonConverter : JsonConverter |
There was a problem hiding this comment.
Suggested change
| public class ClaimJsonConverter : JsonConverter | |
| public class ClaimJsonConverter : JsonConverter<Claim> |
There was a problem hiding this comment.
thank you, missed that, it is fixed now
|
Hey, Vitaly. |
Uses generic version for JsonConverter
AleF83
approved these changes
Aug 21, 2019
AleF83
added a commit
that referenced
this pull request
Aug 21, 2019
|
@vitalyal I've pushed new image to DockerHub. |
|
@AleF83 thank you for publishing and for the project itself! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Here is a PR with support for custom identity resources and claims. Config could look like:
USERS_CONFIGURATION_INLINE: | [ { "SubjectId":"1", "Username":"User1", "Password":"pwd", "Claims":[{ "Type": "tenantId", "Value": "sp", },{ "Type": "group", "Value": "group1", },{ "Type": "group", "Value": "group2", }] } ] IDENTITY_RESOURCES_INLINE: | [ { "Name": "tenant", "ClaimTypes": ["tenantId"] }, { "Name": "roles", "ClaimTypes": ["role"] }, { "Name": "groups", "ClaimTypes": ["group"] }, ]I'm not sure if such customization should be added to readme example