Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken snapshot unit tests #1

Closed
stufield opened this issue Sep 18, 2023 · 1 comment · Fixed by #5
Closed

Fix broken snapshot unit tests #1

stufield opened this issue Sep 18, 2023 · 1 comment · Fixed by #5
Assignees
@amanda-hi

Comments

@stufield
Copy link
Contributor

Snapshots for plotConcord() are broken because they were build on a previous version of the function.

  • they need to be updated and run on Mac or Linux?
  • not sure which is best but which ever gives best generalized coverage (Windows may not)
  • there are currently skip()s in place which is why the build checks pass in Windows
@amanda-hi
Copy link
Contributor

Looking into this now!

amanda-hi added a commit that referenced this issue Sep 18, 2023
@amanda-hi
Update plotConcord() snapshot unit tests
ff497e6 
- `geom_abline()` is now used in place of `geom_line()`, which resulted
in a modification to the snapshot tests
- created new snapshots for all relevant plotConcord() tests
- fixes #1
@amanda-hi amanda-hi mentioned this issue Sep 19, 2023
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amanda-hi amanda-hi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update plotConcord() snapshot unit tests SomaLogic/SomaPlotr
2 participants
@stufield @amanda-hi