Improve S4328 (no-implicit-dependencies): check package.json files in all levels up #3102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yassin-kammoun-sonarsource
approved these changes
Apr 11, 2022
Comment on lines
+176
to
+181
| const upperDir = path.dirname(dirname); | ||
| if (upperDir === dirname) { | ||
| break; | ||
| } else { | ||
| dirname = upperDir; | ||
| } |
There was a problem hiding this comment.
Food for thought...
Just saying, and not sure if it would make the code much more readable, but we could get rid of the if-break-else thing by turning the infinite while loop into a do-while loop.
There was a problem hiding this comment.
I see the point but not sure it's clearer with do-while
|
SonarQube Quality Gate
|
|
Do you know when this will be released? |
|
Hello @gpessa, this improvement is already available on SonarCloud, and it will be part of SonarQube 9.5, whose release is planned for early June. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2682