Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve S138 ('sonar-max-lines-per-function'): Ignore React Functional Components #3104

Merged
merged 1 commit into from
Apr 14, 2022
Merged

Improve S138 ('sonar-max-lines-per-function'): Ignore React Functional Components #3104

merged 1 commit into from
Apr 14, 2022

Conversation

yassin-kammoun-sonarsource
Copy link
Contributor

Fixes #1762

@sonarsource-next
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@yassin-kammoun-sonarsource yassin-kammoun-sonarsource requested review from vilchik-elena and saberduck and removed request for vilchik-elena April 12, 2022 12:25
@saberduck saberduck merged commit 168e2fb into master Apr 14, 2022
@saberduck saberduck deleted the issue-1762 branch April 14, 2022 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saberduck saberduck saberduck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RSPEC-138 | JS | Functions should not have too many lines of code | React Functional Component
2 participants
@yassin-kammoun-sonarsource @saberduck