Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache RegisterNodeAction checks result per SyntaxTree #8406

Closed
sebastien-marichal opened this issue Nov 24, 2023 · 0 comments · Fixed by #8414
Closed

Cache RegisterNodeAction checks result per SyntaxTree #8406

sebastien-marichal opened this issue Nov 24, 2023 · 0 comments · Fixed by #8414
Assignees
@sebastien-marichal
Labels
Type: Performance It takes too long.
Milestone
9.15

Comments

@sebastien-marichal
Copy link
Contributor

sebastien-marichal commented Nov 24, 2023 •
edited
Loading

The Execute method in SonarAnalysisContext class is doing checks multiple time per SyntaxTree.

Caching the results of those checks when registering for the SyntaxNodeAction (which is the one we use the most) will improve performance in time and allocations.

As a first step, this caching will happen only in SonarCompilationStartContext.

See #8414 for more details
@sebastien-marichal sebastien-marichal self-assigned this Nov 24, 2023
@sebastien-marichal sebastien-marichal mentioned this issue Nov 24, 2023
Closed
@sebastien-marichal sebastien-marichal mentioned this issue Nov 27, 2023
Closed
@sebastien-marichal sebastien-marichal mentioned this issue Nov 27, 2023
Merged
@sebastien-marichal sebastien-marichal changed the title Cache ShouldAnalyzeTree results for better performance Cache RegisterNodeAction checks result per SyntaxTree Nov 29, 2023
@sebastien-marichal sebastien-marichal added this to the 9.15 milestone Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sebastien-marichal sebastien-marichal

Labels
Type: Performance It takes too long.
Projects
None yet
Milestone
9.15
2 participants
@martin-strecker-sonarsource @sebastien-marichal