Cache ShouldAnalyzeTree results for better performance #8411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
| @@ -47,6 +47,9 @@ public abstract class SonarAnalysisContextBase<TContext> : SonarAnalysisContextB | |||
| public SonarAnalysisContext AnalysisContext { get; } | |||
| public TContext Context { get; } | |||
|
|
|||
| private readonly ConcurrentDictionary<SyntaxTree, bool> shouldAnalyzeTreeCache = new(); | |||
There was a problem hiding this comment.
Please open another PR, where the ConcurrentDictionary<SyntaxTree, bool> is used the same way as lastShouldAnalyze in https://github.com/SonarSource/sonar-dotnet/pull/8407/files
- Caches the result of ShouldAnalyzeTree && LegacyIsRegisteredActionEnabled && ShouldAnalyzeRazorFile
- Is scoped by the capture in the CompilationStart
- Is scoped to RegisterNodeAction only
That way, we can compare the results between lastShouldAnalyze and the concurrent dict.
|
Closing this PR in favor of #8414. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8406
Solution using
ConcurrentDirctionarywithin theAnalysisContext.On oqtane framework, before changes:
After changes:
From RegisterNodeAction point of view:
Before:
After: