Add C# 9 tests for S4004, S2971, S3240, S1862 and S2760 #3710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrei-epure-sonarsource
changed the title
andrei-epure-sonarsource
force-pushed
the
andrei/cs9-uts-4
branch
from
58fa881
to
b171ec7
Compare
...lyzer-dotnet/tests/SonarAnalyzer.UnitTest/TestCases/ConditionalSimplification.FromCSharp9.cs
Show resolved
Hide resolved
costin-zaharia-sonarsource
approved these changes
Nov 4, 2020
...lyzer-dotnet/tests/SonarAnalyzer.UnitTest/TestCases/ConditionalSimplification.FromCSharp9.cs
Outdated
Show resolved
Hide resolved
...r-dotnet/tests/SonarAnalyzer.UnitTest/TestCases/ConditionalStructureSameCondition.CSharp9.cs
Outdated
Show resolved
Hide resolved
...r-dotnet/tests/SonarAnalyzer.UnitTest/TestCases/ConditionalStructureSameCondition.CSharp9.cs
Show resolved
Hide resolved
...lyzer-dotnet/tests/SonarAnalyzer.UnitTest/TestCases/ConditionalsWithSameCondition.CSharp9.cs
Show resolved
Hide resolved
costin-zaharia-sonarsource
assigned andrei-epure-sonarsource and unassigned costin-zaharia-sonarsource
github-actions
bot
assigned costin-zaharia-sonarsource and unassigned andrei-epure-sonarsource and costin-zaharia-sonarsource
|
I found that a rule wasn't working due to TopLevelStatements, please have another look, @costin-zaharia-sonarsource , as I've changed the tests a bit |
andrei-epure-sonarsource
force-pushed
the
andrei/cs9-uts-4
branch
from
a140882
to
ec97293
Compare
andrei-epure-sonarsource
force-pushed
the
andrei/cs9-uts-4
branch
from
ec97293
to
deceb1a
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
Kudos, SonarCloud Quality Gate passed!
|
costin-zaharia-sonarsource
assigned andrei-epure-sonarsource and unassigned costin-zaharia-sonarsource
Corniel
pushed a commit
to Corniel/sonar-csharp
that referenced
this pull request
Nov 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #3668