Add C# 9 tests for 5 rules #3713
Conversation
| @@ -47,6 +47,15 @@ public class CookieShouldBeHttpOnlyTest | |||
| new CookieShouldBeHttpOnly(AnalyzerConfiguration.AlwaysEnabled), | |||
| additionalReferences: GetAdditionalReferences_NetCore()); | |||
|
|
|||
| [TestMethod] | |||
| [TestCategory("Rule")] | |||
| public void CookiesShouldBeHttpOnly_NetCore_CSharp9() => | |||
There was a problem hiding this comment.
pedantic: this is now just ".Net" :)
| @@ -64,6 +64,15 @@ public class CookieShouldBeSecureTest | |||
| new CookieShouldBeSecure(AnalyzerConfiguration.AlwaysEnabled), | |||
| additionalReferences: GetAdditionalReferences_NetCore()); | |||
|
|
|||
| [TestMethod] | |||
| [TestCategory("Rule")] | |||
| public void CookiesShouldBeSecure_NetCore_CSharp9() => | |||
There was a problem hiding this comment.
pedantic: like in previous comment, I would remove the mention of the framework
| { | ||
| void IsPattern() | ||
| { | ||
|
|
There was a problem hiding this comment.
pedantic: empty line
|
|
||
| void IsNotPattern() | ||
| { | ||
|
|
There was a problem hiding this comment.
pedantic: empty line
se also in the other methods
| // See https://github.com/dotnet/roslyn/issues/45510 | ||
| namespace System.Runtime.CompilerServices | ||
| { | ||
| public class IsExternalInit { } | ||
| } |
There was a problem hiding this comment.
I think you need to rebase on master and remove this, otherwise this will break the build after merge.
See also the other files.
costin-zaharia-sonarsource
assigned andrei-epure-sonarsource and unassigned costin-zaharia-sonarsource
andrei-epure-sonarsource
force-pushed
the
andrei/cs9-uts-5
branch
from
6db70c0
to
8d03f12
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
Kudos, SonarCloud Quality Gate passed!
|
Related to #3668