-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add C#9 tests for S3902,S3885,S1147,S1215,S3971,S1696,S2221,S3981,S2365,S4015 #3737
Conversation
3d3d248
to
a2f8341
Compare
...lyzer-dotnet/tests/SonarAnalyzer.UnitTest/TestCases/DoNotDecreaseMemberVisibility.CSharp9.cs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few improvements suggested
sonaranalyzer-dotnet/tests/SonarAnalyzer.UnitTest/Rules/DoNotCallGCSuppressFinalizeTest.cs
Outdated
Show resolved
Hide resolved
sonaranalyzer-dotnet/tests/SonarAnalyzer.UnitTest/TestCases/DoNotCallGCSuppressFinalize.Net.cs
Outdated
Show resolved
Hide resolved
...alyzer-dotnet/tests/SonarAnalyzer.UnitTest/TestCases/DoNotCheckZeroSizeCollection.CSharp9.cs
Show resolved
Hide resolved
...nalyzer-dotnet/tests/SonarAnalyzer.UnitTest/TestCases/DoNotCopyArraysInProperties.CSharp9.cs
Show resolved
Hide resolved
...lyzer-dotnet/tests/SonarAnalyzer.UnitTest/TestCases/DoNotDecreaseMemberVisibility.CSharp9.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Please rebase and use the new methods before merging.
269fec1
to
43e553e
Compare
43e553e
to
81c6be4
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs |
Kudos, SonarCloud Quality Gate passed! 0 Bugs |
Related to #3668