Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3655: Scaffold rule and UTs #6876

Merged

Conversation

antonioaversa
Copy link
Contributor

@antonioaversa antonioaversa commented Mar 8, 2023

Task 2 of #6794

Previous task: #6844

@antonioaversa antonioaversa changed the title Dummy rule, SymbolicExecutionRunner registration, test methods S3655: Dummy rule, SymbolicExecutionRunner registration, test methods Mar 8, 2023
@antonioaversa antonioaversa marked this pull request as ready for review March 8, 2023 09:19
Copy link
Contributor

@zsolt-kolbay-sonarsource zsolt-kolbay-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Just a comment on formatting.

Copy link
Contributor

@pavel-mikula-sonarsource pavel-mikula-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with small nitpicks. The base class can be removed until we'll need it later.

@pavel-mikula-sonarsource pavel-mikula-sonarsource changed the title S3655: Dummy rule, SymbolicExecutionRunner registration, test methods S3655: Scaffold rule and UTs Mar 9, 2023
@antonioaversa antonioaversa force-pushed the Antonio/S3655-cs9-cs10-syntax-step2 branch from c78e139 to 6a00a5c Compare March 10, 2023 09:26
@sonarcloud
Copy link

sonarcloud bot commented Mar 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarcloud
Copy link

sonarcloud bot commented Mar 10, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

66.7% 66.7% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants