Fix S1123 FN: The explanation should not be null or whitespace #6890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corniel
force-pushed
the
corniel/obsolete-not-null-whitespace
branch
from
149a81b
to
88d64e7
Compare
|
@martin-strecker-sonarsource Given #6593 this should be an easy one, right? |
martin-strecker-sonarsource
requested changes
Mar 17, 2023
analyzers/tests/SonarAnalyzer.UnitTest/TestCases/ObsoleteAttributesNeedExplanation.cs
Show resolved
Hide resolved
analyzers/tests/SonarAnalyzer.UnitTest/TestCases/ObsoleteAttributesNeedExplanation.vb
Show resolved
Hide resolved
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@martin-strecker-sonarsource Moved some test cases to tests that now only run under |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
martin-strecker-sonarsource
approved these changes
Mar 19, 2023
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Kudos, SonarCloud Quality Gate passed!
|
|
Kudos, SonarCloud Quality Gate passed! |
martin-strecker-sonarsource
added
Type: False Negative
pavel-mikula-sonarsource
changed the title
|
Peach validation: No changes found. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned by @martin-strecker-sonarsource reading the arguments should be improved. Result of a remark in #6593 .