S3655: "In" method params #7006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonioaversa
changed the base branch from
master
to
Antonio/S3655-cs9-cs10-syntax-step6-6
Merged
antonioaversa
force-pushed
the
Antonio/S3655-cs9-cs10-syntax-step6-6
branch
from
4cf35c7
to
008e632
Compare
martin-strecker-sonarsource
requested changes
Mar 30, 2023
.../tests/SonarAnalyzer.UnitTest/TestCases/SymbolicExecution/Roslyn/EmptyNullableValueAccess.cs
Outdated
Show resolved
Hide resolved
.../tests/SonarAnalyzer.UnitTest/TestCases/SymbolicExecution/Roslyn/EmptyNullableValueAccess.cs
Outdated
Show resolved
Hide resolved
| } | ||
| } | ||
|
|
||
| class AClassWithStaticValueProperty |
There was a problem hiding this comment.
That is quite a mouth full:
Suggested change
| class AClassWithStaticValueProperty | |
| class StaticValue |
.../tests/SonarAnalyzer.UnitTest/TestCases/SymbolicExecution/Roslyn/EmptyNullableValueAccess.cs
Outdated
Show resolved
Hide resolved
.../tests/SonarAnalyzer.UnitTest/TestCases/SymbolicExecution/Roslyn/EmptyNullableValueAccess.cs
Outdated
Show resolved
Hide resolved
.../tests/SonarAnalyzer.UnitTest/TestCases/SymbolicExecution/Roslyn/EmptyNullableValueAccess.cs
Outdated
Show resolved
Hide resolved
.../tests/SonarAnalyzer.UnitTest/TestCases/SymbolicExecution/Roslyn/EmptyNullableValueAccess.cs
Outdated
Show resolved
Hide resolved
antonioaversa
force-pushed
the
Antonio/S3655-cs9-cs10-syntax-step6-6
branch
from
c9ab91c
to
32b0d1e
Compare
antonioaversa
force-pushed
the
Antonio/S3655-cs9-cs10-syntax-step6-6
branch
from
8856033
to
74ea7d5
Compare
antonioaversa
force-pushed
the
Antonio/S3655-cs9-cs10-syntax-step6-7
branch
from
2bd97e4
to
2006f8e
Compare
antonioaversa
force-pushed
the
Antonio/S3655-cs9-cs10-syntax-step6-6
branch
from
74ea7d5
to
2dea496
Compare
antonioaversa
force-pushed
the
Antonio/S3655-cs9-cs10-syntax-step6-7
branch
from
2006f8e
to
ab806fa
Compare
Base automatically changed from
Antonio/S3655-cs9-cs10-syntax-step6-6
to
feature/SE
March 31, 2023 12:27
antonioaversa
force-pushed
the
Antonio/S3655-cs9-cs10-syntax-step6-7
branch
3 times, most recently
from
13cd855
to
267e7fd
Compare
martin-strecker-sonarsource
requested changes
Apr 4, 2023
.../tests/SonarAnalyzer.UnitTest/TestCases/SymbolicExecution/Roslyn/EmptyNullableValueAccess.cs
Outdated
Show resolved
Hide resolved
antonioaversa
force-pushed
the
Antonio/S3655-cs9-cs10-syntax-step6-7
branch
from
9fceacf
to
b9ec45d
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
Kudos, SonarCloud Quality Gate passed!
|
martin-strecker-sonarsource
approved these changes
Apr 5, 2023
martin-strecker-sonarsource
deleted the
Antonio/S3655-cs9-cs10-syntax-step6-7
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 7 of task 6 of #6794
Previous task: #7000
Addresses:
feature/SE, reviewed twice due to a change of base branch as explained here;The idea was to assert all (again) is to be sure that the pairing (left vs. right) doesn't go out of sync. That would ensure that it works, and that it works for a good reason. In theory, the pairing could go out of sync somewhere and it could end up as a green test by coincidence.