Fix S1125 CodeFix: C# pattern matching in conditional operator #7719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
452
to
475
| public static bool IsTrue(this SyntaxNode node) => | ||
| node switch | ||
| { | ||
| { RawKind: (int)SyntaxKind.TrueLiteralExpression } => true, // true | ||
| { RawKind: (int)SyntaxKind.LogicalNotExpression } => IsFalse(((PrefixUnaryExpressionSyntax)node).Operand), // !false | ||
| { RawKind: (int)SyntaxKindEx.ConstantPattern } => IsTrue(((ConstantPatternSyntaxWrapper)node).Expression), // is true | ||
| { RawKind: (int)SyntaxKindEx.NotPattern } => IsFalse(((UnaryPatternSyntaxWrapper)node).Pattern), // is not false | ||
| { RawKind: (int)SyntaxKind.ParenthesizedExpression } => IsTrue(((ParenthesizedExpressionSyntax)node).Expression), // (true) | ||
| { RawKind: (int)SyntaxKindEx.ParenthesizedPattern } => IsTrue(((ParenthesizedPatternSyntaxWrapper)node).Pattern), // is (true) | ||
| _ => false, | ||
| }; | ||
|
|
||
| public static bool IsFalse(this SyntaxNode node) => | ||
| node switch | ||
| { | ||
| { RawKind: (int)SyntaxKind.FalseLiteralExpression } => true, // false | ||
| { RawKind: (int)SyntaxKind.LogicalNotExpression } => IsTrue(((PrefixUnaryExpressionSyntax)node).Operand), // !true | ||
| { RawKind: (int)SyntaxKindEx.ConstantPattern } => IsFalse(((ConstantPatternSyntaxWrapper)node).Expression), // is false | ||
| { RawKind: (int)SyntaxKindEx.NotPattern } => IsTrue(((UnaryPatternSyntaxWrapper)node).Pattern), // is not true | ||
| { RawKind: (int)SyntaxKind.ParenthesizedExpression } => IsFalse(((ParenthesizedExpressionSyntax)node).Expression), // (false) | ||
| { RawKind: (int)SyntaxKindEx.ParenthesizedPattern } => IsFalse(((ParenthesizedPatternSyntaxWrapper)node).Pattern), // is (false) | ||
| _ => false, | ||
| }; | ||
|
|
There was a problem hiding this comment.
Methods from #7687 (not merged yet)
cristian-ambrosini-sonarsource
requested a review
from martin-strecker-sonarsource
martin-strecker-sonarsource
requested changes
Aug 3, 2023
analyzers/src/SonarAnalyzer.CSharp/Rules/BooleanLiteralUnnecessaryCodeFix.cs
Outdated
Show resolved
Hide resolved
cristian-ambrosini-sonarsource
requested a review
from martin-strecker-sonarsource
martin-strecker-sonarsource
requested changes
Aug 3, 2023
analyzers/src/SonarAnalyzer.CSharp/Rules/BooleanLiteralUnnecessaryCodeFix.cs
Outdated
Show resolved
Hide resolved
cristian-ambrosini-sonarsource
requested a review
from martin-strecker-sonarsource
martin-strecker-sonarsource
approved these changes
Aug 3, 2023
martin-strecker-sonarsource
force-pushed
the
cristian/codefix-S1125-fix
branch
from
36d4601
to
1227edd
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
SonarCloud Quality Gate failed.
|
pavel-mikula-sonarsource
changed the title
|
Peach validation: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2618
Fixes #7462